Follow-up of bug 1711274: Missing fluent translations and other porting issues
Categories
(Thunderbird :: Preferences, defect)
Tracking
(thunderbird_esr78 unaffected, thunderbird_esr91 wontfix)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | unaffected |
thunderbird_esr91 | --- | wontfix |
People
(Reporter: henry-x, Assigned: henry-x)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Bug 1711274 ported extensionControlled.js from mozilla-central into comm-central, but it has a few problems:
- It contains dictionary objects (https://searchfox.org/comm-central/rev/2b9757e10d3304dbb539a4b3fdded6699db54b20/mail/components/preferences/extensionControlled.js#58-79), but I think only the
proxy.settings
entry is actually used. The unused entries should be removed. If there is only one used entry, some of the methods that use these dictionaries could be made specific to this setting, which would make the code less convoluted. initListenersForPrefChange
is defined but unused. It should be removed.- We are missing fluent entries for at least
extension-controlled-proxy-config
andextension-controlled-enable
. - We are missing the image source
"chrome://browser/skin/menu.svg"
. showEnableExtensionMessage
uses xul elements in a semantically incorrect way (e.g., a xul:image is used as a close button, and axul:label
is used to display a message). We should probably change this to html as well. Note: this is inherited from mozilla-central.- There are
html:img
elements with noalt
attribute, or some accessible name. Note: this is also inherited from mozilla-central.
Comment 1•3 years ago
|
||
(In reply to Henry Wilkes [:henry] from comment #0)
- We are missing the image source
"chrome://browser/skin/menu.svg"
.
We can use "chrome://messenger/skin/icons/appbutton.svg"
instead.
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
(In reply to Wayne Mery (:wsmwk) from comment #2)
This affects v91?
I think so. Bug 1711274 caused this, and it has a target milestone of 91. I'm not sure what the proper way to check is, but the changes are part of 91 Beta, e.g. https://hg.mozilla.org/comm-central/file/BETA_91_BASE/mail/components/preferences/extensionControlled.js
Assignee | ||
Comment 4•3 years ago
|
||
We were missing lots of fluent ids that the previous code would have needed.
We only have extension control for proxy.settings, so this was simplified.
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/3cb7432dd334
Simplify extensionControlled and add missing fluent translation. r=mkmelin
Assignee | ||
Comment 6•3 years ago
|
||
Introduces new strings, so can't fix for 91.
Description
•