lightning read only caldav calendar losing RO setting upon start
Categories
(Calendar :: Provider: CalDAV, defect)
Tracking
(thunderbird_esr91+ verified, thunderbird93+ fixed)
People
(Reporter: je-vv, Assigned: darktrojan)
References
(Regression, )
Details
(Keywords: regression)
Attachments
(1 file)
Bug 1729235 - Don't clear read-only status of CalDAV calendars even if it is writeable. r=mschroeder
(deleted),
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr91+
|
Details |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0
Steps to reproduce:
Just start Thunderbird
Actual results:
You'll get after a little while several reminders you can't dismiss because they correspond to read only remote caldav calendar. You go and open the settings for that calendar, and you notice the "read only" setting is lost. You go and set it back to "read only", and now you can dismiss those old reminders. But if you close TB, and start it over again, once again the calendar comes with the "read only" setting lost, and you have to do the process all over again, every time starting TB.
Really annoying.
Expected results:
The remote caldav calendars should keep the settings provided by the user. Whether not read only, or read only, that setting should be kept as per the user configuration, and should be kept across TB turning off and turning back on...
Updated•3 years ago
|
Comment 1•3 years ago
|
||
Confirmed with Thunderbird 91.1.0 on macOS.
Comment 2•3 years ago
|
||
Same thing happens for me without a restart. You just have to enable a disabled read-only CalDAV calendar, which clears the read-only state.
Comment 3•3 years ago
|
||
Side note: There seem to be two instances (https://searchfox.org/comm-central/search?q=mReadOnly&path=calendar%2Fproviders%2Fcaldav%2FCalDavCalendar.jsm) where this.mReadOnly
is used instead of this.readOnly
as mReadOnly
does not exist.
Assignee | ||
Comment 6•3 years ago
|
||
Ah, okay, this is a bug and I'm not going mad then! I'll look into it.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 7•3 years ago
|
||
Bug 1665203 set the read-only status to match the user's privileges on the server, but this clears a user-set read-only status if the user can write to the calendar but doesn't want to.
Also, gets rid of mReadOnly as it does nothing, and renames mDisabled to make it more obvious what it is.
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/c7904afdc4d3
Don't clear read-only status of CalDAV calendars even if it is writeable. r=mschroeder
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 10•3 years ago
|
||
Comment on attachment 9241993 [details]
Bug 1729235 - Don't clear read-only status of CalDAV calendars even if it is writeable. r=mschroeder
[Approval Request Comment]
Regression caused by (bug #): bug 1665203
User impact if declined: calendars stop being read-only when the user has set them to be
Testing completed (on c-c, etc.): landed yesterday
Risk to taking this patch (and alternatives if risky): low but non-zero chance of something weird happening
Updated•3 years ago
|
Comment 11•3 years ago
|
||
Comment on attachment 9241993 [details]
Bug 1729235 - Don't clear read-only status of CalDAV calendars even if it is writeable. r=mschroeder
[Triage Comment]
Approved for beta
Comment 12•3 years ago
|
||
bugherder uplift |
Thunderbird 93.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/386347826e41
Assignee | ||
Comment 13•3 years ago
|
||
Comment on attachment 9241993 [details]
Bug 1729235 - Don't clear read-only status of CalDAV calendars even if it is writeable. r=mschroeder
[Approval Request Comment]
Regression caused by (bug #): bug 1665203
User impact if declined: calendars stop being read-only when the user has set them to be
Testing completed (on c-c, etc.): in 93.0b5
Risk to taking this patch (and alternatives if risky): low but non-zero chance of something weird happening, no reports so far
Comment 14•3 years ago
|
||
Comment on attachment 9241993 [details]
Bug 1729235 - Don't clear read-only status of CalDAV calendars even if it is writeable. r=mschroeder
[Triage Comment]
Approved for esr91
Comment 15•3 years ago
|
||
bugherder uplift |
Thunderbird 91.2.1:
https://hg.mozilla.org/releases/comm-esr91/rev/45814a75454b
Comment 17•3 years ago
|
||
Verified when testing the 91.2.1 release candidate on Windows 10.
Comment 18•2 years ago
|
||
Hello,
the problem seems to be still present in the 102.4.0 64 bits version.
I have the same symptoms with a caldav oracle convergence calendar.
Description
•