User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Upgrade from TB 78 to TB 91

Actual results:

LDAP address book query showing no results

Thunderbird 78 LDAP query : (|(|(|(|(|(|(|(|(|(|(|(cn=test)(givenName=test))(sn=test))(mozillaNickname=test))(mail=test))(mozillaSecondEmail=test))(description=test))(o=test))(ou=test))(title=test))(mozillaWorkUrl=test))(mozillaHomeUrl=test))
Using our ldap server, we get results with this query

Thunderbird 91 query : (|(|(|(|(|(|(|(|(|(|(|(cn=test)(givenName=test))(sn=test))(mozillaNickname=test))(mail=test))(mozillaSecondEmail=test))(&(null=TRUE)(description=test)))(o=test))(ou=test))(title=test))(mozillaWorkUrl=test))(mozillaHomeUrl=test))
We get no results with this query. Seems like &(null=TRUE) is responsible, but i am not an ldap expert so cant get why ?

Expected results:

Show results

Some attrs in the query string have no attrMap value, so don't include them in the search filter.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/5bc657413e7b
Prevent null attr in LDAP search filter. r=darktrojan

Comment on attachment 9239749 [details]
Bug 1729278 - Prevent null attr in LDAP search filter. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #): bug 1696625
User impact if declined: Searching ldap returns no result for some servers
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment on attachment 9239749 [details]
Bug 1729278 - Prevent null attr in LDAP search filter. r=darktrojan

[Triage Comment]
Approved for beta

Thunderbird 93.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/4d7e8f1c9e97

Comment on attachment 9239749 [details]
Bug 1729278 - Prevent null attr in LDAP search filter. r=darktrojan

[Triage Comment]
Approved for esr91

Thunderbird 91.1.1:
https://hg.mozilla.org/releases/comm-esr91/rev/ee530d0ec5a3