"What's New Page" shouldn't contain `all` locale
Categories
(Firefox :: General, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox-esr91 | --- | fixed |
firefox92 | --- | fixed |
firefox93 | --- | fixed |
firefox94 | --- | fixed |
People
(Reporter: freddy, Assigned: freddy)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
pmac mentioned this in the #firefox chat room.
We're pointing to "all", which is a non-localized version of the page.
Dropping this path would be better.
Assignee | ||
Comment 1•3 years ago
|
||
Comment 2•3 years ago
|
||
pmac, does it need to be changed on all Firefox branches after it lands? (I am specifically thinking of ESR 91)
Comment 4•3 years ago
|
||
(In reply to Pascal Chevrel:pascalc from comment #2)
pmac, does it need to be changed on all Firefox branches after it lands? (I am specifically thinking of ESR 91)
If any of the WNP URLs contain the all/
suffix then it should be removed. We rely on the whatsnew/
URL to be a redirector for campaigns that need to be restricted to only certain countries due to product availability or sometimes legal requirements. I'm not sure how the all/
suffix ended up in the code, but I'm guessing someone copied the URL after they'd been redirected to that variant.
(In reply to Frederik Braun [:freddy] from comment #0)
pmac mentioned this in the #firefox chat room.
We're pointing to "all", which is a non-localized version of the page.
Dropping this path would be better.
Yes. And the patch looks perfect to me. Thanks! r+
Updated•3 years ago
|
Comment 5•3 years ago
|
||
We fixed this on the Balrog side for 92.0 also.
Comment 6•3 years ago
|
||
uplift |
Comment 7•3 years ago
|
||
bugherder |
Description
•