Address book menu lists have lost their icons
Categories
(Thunderbird :: Preferences, defect)
Tracking
(thunderbird_esr91 fixed, thunderbird93 fixed)
People
(Reporter: darktrojan, Assigned: Paenglab)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
henry-x
:
review+
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr91+
|
Details | Diff | Splinter Review |
In the composition preferences are three drop-down lists of address books. These are supposed to have icons, but the CSS for the icons is in messenger.css which is no longer included in the preferences.
The same list widget (<menulist is="menulist-addrbooks">
) is used elsewhere so the style needs to remain somewhere useful.
Reporter | ||
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Henry, you are the set icon directly specialist. ;-)
How about this? This patch removes the need of messenger.css for this specific icons. It's not a HTML conversion as the menulists are still using XUL.
Comment 2•3 years ago
|
||
Comment 3•3 years ago
|
||
Sorry, I got "address.svg" and "ablist.svg" the wrong way around in my initial comment, but I edited it the right way around now.
Comment 4•3 years ago
|
||
Assignee | ||
Comment 5•3 years ago
|
||
Yes, your proposals are better.
Assignee | ||
Comment 6•3 years ago
|
||
Fixed the linting.
Comment 7•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/2990d8241079
Set abMenuItem images in JS directly. r=henry
Assignee | ||
Comment 9•3 years ago
|
||
Comment on attachment 9240338 [details] [diff] [review]
1729873-abMenuItem-image.patch
[Approval Request Comment]
User impact if declined: no icons in menulists in compose prefs
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Comment 10•3 years ago
|
||
Comment on attachment 9240338 [details] [diff] [review]
1729873-abMenuItem-image.patch
[Triage Comment]
approved for beta
Comment 11•3 years ago
|
||
bugherder uplift |
Thunderbird 93.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/c727105a1d74
Comment 12•3 years ago
|
||
Comment on attachment 9240338 [details] [diff] [review]
1729873-abMenuItem-image.patch
[Triage Comment]
Approved for esr91
Comment 13•3 years ago
|
||
bugherder uplift |
Thunderbird 91.1.1:
https://hg.mozilla.org/releases/comm-esr91/rev/ce7337401d2b
Description
•