White background into Dark theme into "From" dropdown when composing messages
Categories
(Thunderbird :: Message Compose Window, defect)
Tracking
(thunderbird_esr91? fixed, thunderbird93? fixed)
People
(Reporter: eduardomozart182, Assigned: Paenglab)
References
Details
(Keywords: regression)
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
aleca
:
review+
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr91+
|
Details | Diff | Splinter Review |
2021-09-09 15_35_43-.png
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.63 Safari/537.36
Steps to reproduce:
- Open Thunderbird.
- Reply or compose a new message.
Actual results:
The "From" dropdown shows a White background and white fontcolor so it's not possible to see the accounts from dropdown.
Expected results:
The "From" dropdown should show a Black background and white fontcolor into dropdown so it would be possible to see the accounts from dropdown when using Dark Thunderbird theme.
|
Assignee | |
Comment 1•3 years ago
|
||
Alessandro, you can test this on Windows 10 with setting browser.display.windows.non_native_menus to 0.
|
Reporter | |
Comment 2•3 years ago
|
||
I tried to apply this fix into userChrome.css file but the issue persists into my system (Windows 7 x64). Tried to change the setting browser.display.windows.non_native_menus and it didn't worked neither. I tried to change the "transparent" keyword to "black" but no avail.
|
|
Assignee | |
Comment 3•3 years ago
|
||
In userChrome.css you need to try with !important added. Here my build works on Win7 Basic.
|
||
Updated•3 years ago
|
|
|
||
Comment 4•3 years ago
|
||
|
|
Assignee | |
Updated•3 years ago
|
|
|
Reporter | |
Comment 5•3 years ago
|
||
Into my setup (Win7 Pro x64/Thunderbird 91), it didn't worked into userChrome.css, even with the ''important'' flag appended. The ''browser.display.windows.non_native_menus'' property was set to "2", I tried changing it to "0" and restarting Thunderbird 91, but the issue persisted.
I had to remove ":root[lwt-tree] " in front of element so it started working.
Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/efe2bf7d4803
[Windows] Set the msgIdentityPopup background color with native menus. r=aleca
|
|
Assignee | |
Comment 7•3 years ago
|
||
Comment on attachment 9240570 [details] [diff] [review]
1729977-msgIdentityPopup-color.patch
[Approval Request Comment]
User impact if declined: on Windows 7 with dark theme unreadable content in msgIdentityPopup
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
|
||
Comment 8•3 years ago
|
||
Comment on attachment 9240570 [details] [diff] [review]
1729977-msgIdentityPopup-color.patch
[Triage Comment]
approved for beta
|
||
Comment 9•3 years ago
|
||
| bugherder uplift | ||
Thunderbird 93.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/11ab0ee3d549
|
|
||
Comment 10•3 years ago
|
||
Comment on attachment 9240570 [details] [diff] [review]
1729977-msgIdentityPopup-color.patch
[Triage Comment]
Approved for esr91
|
|
||
Comment 11•3 years ago
|
||
| bugherder uplift | ||
Thunderbird 91.1.1:
https://hg.mozilla.org/releases/comm-esr91/rev/d109fc1b358e
Description
•