Closed Bug 1730093 Opened 3 years ago Closed 3 years ago

Cache text and line offsets

Categories

(Core :: Disability Access APIs, task)

task

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: Jamie, Assigned: Jamie)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

When sending cache data for a subtree, we need to send the text of TextLeafAccessibles, as well as line offsets. We also need to do this when a text leaf is updated (which is handled by TextUpdater). TextLeafPoint and HyperTextAccessible need to be taught how to use that cached data.

We might already cache the text of TextLeafAccessibles with the name caching implemented in bug 1700264. However, if we do, we wouldn't be keeping it up to date, as TextLeafAccessibles don't (and shouldn't) fire name change events.

Assignee: nobody → jteh
Depends on: 1731154
Depends on: 1731374
No longer blocks: a11y-ctw
Status: NEW → ASSIGNED
Blocks: 1730088
No longer depends on: 1730088

As part of this, we no longer cache the name for text accessibles, as that would be redundant.
Instead, we return the cached text in RemoteAccessible::Name.

This uses the unified AppendTextTo and TextLength, as well as adding support for cached line start boundaries.

Pushed by jteh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/593b86a95509 part 1: Push text and line start offsets to the cache. r=eeejay https://hg.mozilla.org/integration/autoland/rev/e89a1d6424f7 part 2: Move AppendTextTo to Accessible and implement it for RemoteAccessible. r=eeejay https://hg.mozilla.org/integration/autoland/rev/98e556a28416 part 3: Support RemoteAccessible in nsAccUtils::TextLength. r=eeejay https://hg.mozilla.org/integration/autoland/rev/83bcd4379c5e part 4: Support RemoteAccessible in TextLeafPoint. r=eeejay
Blocks: 1734583
Blocks: 1735101
Blocks: 1739560
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: