Closed
Bug 1731154
Opened 3 years ago
Closed 3 years ago
Make AccAttributes entries movable and avoid copies.
Categories
(Core :: Disability Access APIs, defect, P1)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
94 Branch
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: eeejay, Assigned: eeejay)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
Bug 1731154 - Add move semantics to AccAttributes and use value references to avoid copies. r?morgan
(deleted),
text/x-phabricator-request
|
Details |
We currently need to use copyable arrays in AccAttributes. We should be avoiding copies and using references and moves whenever possible.
|
Assignee | |
Comment 1•3 years ago
|
||
Changed the array type to nsTArray to avoid copies and get compile-time
errors if we ever try to do that. To set an array as a value, it must be
moved.
|
||
Updated•3 years ago
|
Assignee: nobody → eitan
Status: NEW → ASSIGNED
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/176469dcdeba
Add move semantics to AccAttributes and use value references to avoid copies. r=morgan
|
||
Comment 4•3 years ago
|
||
Backed out changeset 176469dcdeba (Bug 1731154) for causing bc failures on browser_attributed_text.js.
Backout link
Push with failures - bc4
Failure Log
Flags: needinfo?(eitan)
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/003ef3c8730c
Add move semantics to AccAttributes and use value references to avoid copies. r=morgan
|
|
Assignee | |
Updated•3 years ago
|
Flags: needinfo?(eitan)
|
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•