Match console messages on target exact window (and not on the window "tree" anymore) when we have same-origin iframe targets
Categories
(DevTools :: Console, task)
Tracking
(firefox94 fixed)
Tracking | Status | |
---|---|---|
firefox94 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
(Whiteboard: dt-perf-stability-mvp)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
At the moment, when checking which messages should be sent to the client, we are checking if the window the message was emitted from belongs to the "target window tree" (see https://searchfox.org/mozilla-central/rev/1761c710b035d7dc8892dfa8e56589b4e095221f/devtools/server/actors/resources/error-messages.js#81-83 for example)
With Bug 1685500, we'll have targets for each document, so we can do an exact match on the window instead, as messages from iframes will be included from the iframes targets.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
With dedicated targets for each window, we can now only check that the message
originates from the target window, and not from its window tree
Some tests that were assuming the iframe had the same target as the top level document
are updated.
Depends on D125833
Comment 3•3 years ago
|
||
bugherder |
Description
•