Closed Bug 1730159 Opened 3 years ago Closed 3 years ago

Match console messages on target exact window (and not on the window "tree" anymore) when we have same-origin iframe targets

Categories

(DevTools :: Console, task)

task

Tracking

(firefox94 fixed)

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

(Whiteboard: dt-perf-stability-mvp)

Attachments

(1 file)

At the moment, when checking which messages should be sent to the client, we are checking if the window the message was emitted from belongs to the "target window tree" (see https://searchfox.org/mozilla-central/rev/1761c710b035d7dc8892dfa8e56589b4e095221f/devtools/server/actors/resources/error-messages.js#81-83 for example)

With Bug 1685500, we'll have targets for each document, so we can do an exact match on the window instead, as messages from iframes will be included from the iframes targets.

Whiteboard: dt-perf-stability-mvp
Blocks: 1730160
Blocks: 1730162
No longer blocks: 1730162
No longer blocks: 1730160

With dedicated targets for each window, we can now only check that the message
originates from the target window, and not from its window tree
Some tests that were assuming the iframe had the same target as the top level document
are updated.

Depends on D125833

Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7b38889adbb6 [devtools] Only match console messages of exact same window. r=bomsy.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
Blocks: 1733380
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: