Closed Bug 1730160 Opened 3 years ago Closed 3 years ago

Match content network requests on target exact window (and not on the window "tree" anymore) when we have same-origin iframe targets

Categories

(DevTools :: Netmonitor, task)

task

Tracking

(firefox94 fixed)

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

(Whiteboard: dt-perf-stability-mvp)

Attachments

(1 file)

At the moment, when checking which requests should be sent to the client, we are checking if the window the request was emitted from belongs to the "target window tree" (see https://searchfox.org/mozilla-central/rev/1761c710b035d7dc8892dfa8e56589b4e095221f/devtools/server/actors/network-monitor/network-observer.js#109-120 for example)

With Bug 1685500, we'll have targets for each document, so we can do an exact match on the window instead, as requests from iframes will be included from the iframes targets.

Blocks: 1730162
No longer blocks: 1730162
No longer depends on: 1730159

When we create targets for every frame, we need to tighten our different filters
so requests/resources are duplicated (we would get them from both the top-level
target as well as from their iframe).

Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/af80802b2175 [devtools] Filter content network event against exact target browsingContext/window when EFT is enabled. r=bomsy.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: