Closed Bug 1730167 Opened 3 years ago Closed 3 years ago

Use appropriate target's walker front for expanding iframe node in markup view when we have same-origin iframe targets

Categories

(DevTools :: Inspector, task)

Product:
DevTools
Component:
Inspector
Type:
task

Tracking

(firefox94 fixed)

Status:
RESOLVED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox94 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

(Whiteboard: dt-perf-stability-mvp)

Attachments

(3 files)

Bug 1730167 - [devtools] Use appropriate walker front to retrieve frame children when EFT is enabled. r=ochameau
(deleted), text/x-phabricator-request
Details
Bug 1730167 - [devtools] Use appropriate walker front to retrieve frame children when EFT is enabled in a11y panel. r=ochameau.
(deleted), text/x-phabricator-request
Details
Bug 1730167 - [devtools] Replace usage of isRemoteFrame with isFrameWithChildTarget. r=ochameau.
(deleted), text/x-phabricator-request
Details

At the moment, we have a piece of logic in the walker front code to pick up a different walker front to retrieve a node when the node is a remoteFrame (See https://searchfox.org/mozilla-central/rev/1761c710b035d7dc8892dfa8e56589b4e095221f/devtools/client/fronts/walker.js#336-355)

With Bug 1685500, we'll have targets for each document so even children off same-origin iframes should be retrieved by their associated target.

Blocks: 1730170

This is a similar change to what was done to node actors in the previous patch
of this queue.

Depends on D126064

isRemoteFrame was used as a way to know if an iframe was tracked by its own target.
Since we can now have dedicated targets for every iframe, we need to check if a given
iframe is tracked by its dedicated target.

Depends on D126804

Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6f2825300e65 [devtools] Use appropriate walker front to retrieve frame children when EFT is enabled. r=ochameau https://hg.mozilla.org/integration/autoland/rev/11370a6988be [devtools] Use appropriate walker front to retrieve frame children when EFT is enabled in a11y panel. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/6075634c3db2 [devtools] Replace usage of isRemoteFrame with isFrameWithChildTarget. r=ochameau.

Backed out for causing mochitest failures.

Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8fede56e49dc [devtools] Use appropriate walker front to retrieve frame children when EFT is enabled. r=ochameau https://hg.mozilla.org/integration/autoland/rev/a8809fa08187 [devtools] Use appropriate walker front to retrieve frame children when EFT is enabled in a11y panel. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/30b0fc1909f5 [devtools] Replace usage of isRemoteFrame with isFrameWithChildTarget. r=ochameau.

https://hg.mozilla.org/mozilla-central/rev/8fede56e49dc
https://hg.mozilla.org/mozilla-central/rev/a8809fa08187
https://hg.mozilla.org/mozilla-central/rev/30b0fc1909f5

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
Flags: needinfo?(nchevobbe)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: