Closed
Bug 1730170
Opened 3 years ago
Closed 3 years ago
With same-origin iframe targets, results from iframe are duplicated
Categories
(DevTools :: Inspector, task)
DevTools
Inspector
Tracking
(firefox94 fixed)
RESOLVED
FIXED
94 Branch
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
(Whiteboard: dt-perf-stability-mvp)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
With Bug 1685500, we have dedicated target for each document, but it looks like when doing a search that would return results for a same origin iframe, we are also getting the result from the top-level target, which makes the result numbers wrong and navigating from result to result weird.
This might require Bug 1730167 to be properly fixed
|
Assignee | |
Comment 1•3 years ago
|
||
We were getting results of nodes in iframes twice: from the iframe target
as well as from the top-level target.
This is fixed by setting showSubDocuments to false when EFT is enabled.
A test was tweaked in order to retrieve nested iframe node.
Depends on D126065
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/090410cf3b8c [devtools] Fix inspector search when EFT is enabled. r=bomsy.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6c76dff69c0e [devtools] Fix inspector search when EFT is enabled. r=bomsy.
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
|
|
Assignee | |
Updated•3 years ago
|
Flags: needinfo?(nchevobbe)
You need to log in
before you can comment on or make changes to this bug.
Description
•