Closed Bug 1731129 Opened 3 years ago Closed 3 years ago

New > Feed Account is not dark themed

Categories

(Thunderbird :: Theme, defect)

Thunderbird 91
defect

Tracking

(thunderbird_esr91+ fixed, thunderbird93+ fixed)

RESOLVED FIXED
94 Branch
Tracking Status
thunderbird_esr91 + fixed
thunderbird93 + fixed

People

(Reporter: wsmwk, Assigned: Paenglab)

References

Details

Attachments

(3 files)

Seen on 91.1.1 and 93.0b2

Attached patch 1731129-wizard-themeable.patch (deleted) — Splinter Review

wizard.css is a M-C file and needs to be overridden. It uses also platform specific files for macOS and the same file for Linux/Windows. I use now the same styles for all platforms.

accountWizard.css was on all platforms the same -> moved to shared including the rules from imAccountWizard.css which is now deleted.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9241819 - Flags: review?(alessandro)
Comment on attachment 9241819 [details] [diff] [review] 1731129-wizard-themeable.patch Review of attachment 9241819 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks for taking care of this.
Attachment #9241819 - Flags: review?(alessandro) → review+
Target Milestone: --- → 94 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/e31fbbc2f59f
Make the Account wizards themeable. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

[Approval Request Comment]
User impact if declined: not themed wizards
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low but to c-c, beta is different as two wizards aren't HTMLized.

Attachment #9242089 - Flags: approval-comm-beta?

Same patch as for beta. Only one jar.mn file was different.
[Approval Request Comment]
User impact if declined: not themed wizards
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low but to c-c, beta is different as two wizards aren't HTMLized.

Attachment #9242092 - Flags: approval-comm-esr91?

Comment on attachment 9242089 [details] [diff] [review]
1731129-wizard-themeable-beta.patch

[Triage Comment]
Approved for beta

Attachment #9242089 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9242092 [details] [diff] [review]
1731129-wizard-themeable-ESR.patch

[Triage Comment]
Approved for esr91

Attachment #9242092 - Flags: approval-comm-esr91? → approval-comm-esr91+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: