Closed Bug 1731526 Opened 3 years ago Closed 3 years ago

Fix non-unified build errors in accessible/

Categories

(Core :: Disability Access APIs, defect, P3)

All
macOS
defect

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox-esr78 --- wontfix
firefox-esr91 --- wontfix
firefox92 --- wontfix
firefox93 --- wontfix
firefox94 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

Building with ac_add_options --disable-unified-build on macOS hits the following -Wunreachable-code-return warnings-as-errors:

accessible/base/TreeWalker.cpp:151:10: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
accessible/xpcom/xpcAccessibleMacInterface.mm:177:10: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]

Blocks: 1642030

accessible/base/TreeWalker.cpp:151:10: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
accessible/xpcom/xpcAccessibleMacInterface.mm:177:10: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]

Changing severity to P3/S4 for triage

Severity: -- → S4
Priority: -- → P3
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/998408ac9046 Fix non-unified build errors in accessible/. r=eeejay
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
Blocks: non-unified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: