Closed Bug 1731582 (clang-13) Opened 3 years ago Closed 3 years ago

Upgrade llvm toolchain to 13

Categories

(Firefox Build System :: Toolchains, enhancement)

Product:
Firefox Build System
Component:
Toolchains
Type:
enhancement

Tracking

(firefox94 wontfix, firefox95 fixed)

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox94 --- wontfix
firefox95 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Depends on 1 open bug)

Details

(Keywords: perf-alert)

Attachments

(3 files, 1 obsolete file)

Bug 1731582 - Move to clang-13
(deleted), text/x-phabricator-request
Details
Bug 1731582 - starting with clang-13 `Expr::isRValue` has been changed to `Expr::isPRValue`.
(deleted), text/x-phabricator-request
Details
Bug 1731582 - starting with clang-13 some member functions from `StringRef` have been renamed.
(deleted), text/x-phabricator-request
Details

LLVM is currently at 13.0.0-rc3, and the move to final will be these days, so we must be prepared to do the migration.
Unfortunately for the moment I don't see how we can move wasm32-wasi-compiler-rt to clang-13, because the latest version of wasi-sdk doesn't support clang-13 and hence the test suit fails.

Attached file Bug 1731582 - Move to clang-13 (deleted) —
Depends on: 1731957
Depends on: 1731986
Alias: clang-13
Depends on: 1732208
Depends on: 1732235
Depends on: 1731976
Depends on: 1732824
Attachment #9242411 - Attachment description: Bug 1731582 - starting with clang-13 `Expr::isRValue` has been chaged to `Expr::isPRValue`. → Bug 1731582 - starting with clang-13 `Expr::isRValue` has been changed to `Expr::isPRValue`.
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4c7c7f3a978d starting with clang-13 `Expr::isRValue` has been changed to `Expr::isPRValue`. r=glandium https://hg.mozilla.org/integration/autoland/rev/6942cf9ada69 starting with clang-13 some member functions from `StringRef` have been renamed. r=glandium

https://hg.mozilla.org/mozilla-central/rev/4c7c7f3a978d
https://hg.mozilla.org/mozilla-central/rev/6942cf9ada69

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch

(In reply to Andi [:andi] from comment #0)

LLVM is currently at 13.0.0-rc3, and the move to final will be these days, so we must be prepared to do the migration.
Unfortunately for the moment I don't see how we can move wasm32-wasi-compiler-rt to clang-13, because the latest version of wasi-sdk doesn't support clang-13 and hence the test suit fails.

I reached out to Pat Hickey (and pointed him here) to see if there's any chance of a WASI-SDK 13 coming out soon to be compatible with LLVM13. If he replies, I'll post his reply here.

The reply:

Sorry for the delay on a new SDK release. Dan has been working on it the last few weeks and I believe he is just waiting on the latest LLVM project release to become official, it’s currently in release candidates and should be done within a few weeks.

Pat

I did point them to https://github.com/llvm/llvm-project/releases/tag/llvmorg-13.0.0 so they know it's been released.

Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
Attachment #9243947 - Attachment is obsolete: true
Depends on: 1690973
Depends on: 1733908
Depends on: 1735259
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f3cf8baf4f0a Move to clang-13 r=firefox-build-system-reviewers,mhentges
Regressions: 1736539

Backed out changeset f3cf8baf4f0a (Bug 1731582) for causing build bustages.
Backout link
Push with failures
Failure Log

Flags: needinfo?(bpostelnicu)
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7de44eaecb13 Move to clang-13 r=firefox-build-system-reviewers,mhentges,decoder
Status: REOPENED → ASSIGNED
status-firefox94: affected → wontfix
Flags: needinfo?(bpostelnicu)
Target Milestone: 94 Branch → ---
Flags: needinfo?(bpostelnicu)
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dcb91b95f32b Move to clang-13 r=firefox-build-system-reviewers,mhentges,decoder
Status: ASSIGNED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox95: --- → fixed
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/7b2626d4304d Port bug 1731582 - Move to clang-13 rs=bustage-fix
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/6517efe895fb Port bug 1731582 (again) - Move ALL the things to clang-13 rs=bustage-fix
Regressions: 1736970

== Change summary for alert #32016 (as of Thu, 21 Oct 2021 16:25:38 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
3% allrecipes dcf android-hw-g5-7-0-arm7-shippable-qr cold webrender 2,252.73 -> 2,181.54
3% allrecipes fcp android-hw-g5-7-0-arm7-shippable-qr warm webrender 1,800.92 -> 1,744.54
3% allrecipes SpeedIndex android-hw-g5-7-0-arm7-shippable-qr cold webrender 2,806.00 -> 2,719.83
3% allrecipes SpeedIndex android-hw-g5-7-0-arm7-shippable-qr warm webrender 2,356.38 -> 2,284.42
3% allrecipes loadtime android-hw-g5-7-0-arm7-shippable-qr warm webrender 2,377.17 -> 2,311.92
... ... ... ... ...
2% allrecipes dcf android-hw-g5-7-0-arm7-shippable-qr warm webrender 2,250.83 -> 2,195.92

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=32016

Regressions: 1737594
Regressions: 1737618
Regressed by: 1738114
No longer regressed by: 1738114
Regressions: 1738114
Regressions: 1739321
Regressions: 1741454

== Change summary for alert #32142 (as of Wed, 27 Oct 2021 16:41:10 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
6% build times windows2012-32-shippable nightly taskcluster-m5d.4xlarge 1,951.29 -> 1,840.96
4% build times windows2012-64-shippable nightly taskcluster-m5.4xlarge 1,996.99 -> 1,923.03
4% build times osx-shippable nightly taskcluster-c5n.4xlarge 2,617.88 -> 2,524.89

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=32142

13.0.1 RC2 was released a couple of days ago: https://github.com/llvm/llvm-project/releases/tag/llvmorg-13.0.1-rc2

We already have Bug 1744446 in the working.

Blocks: 1764882

REMOVED: Wrong Bug. Aplogies.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: