Enable -Wunused-but-set-parameter warnings
Categories
(Firefox Build System :: General, task, P3)
Tracking
(firefox-esr78 wontfix, firefox-esr91 wontfix, firefox93 wontfix, firefox94 wontfix, firefox95 wontfix, firefox96 fixed)
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files)
|
(deleted),
text/x-phabricator-request
|
Details | |
|
Bug 1737217 - Enable -Wunused-but-set-parameter warnings on clang. r?#firefox-build-system-reviewers
(deleted),
text/x-phabricator-request
|
Details |
clang 13 added a new -Wunused-but-set-parameter warning:
gcc has had an -Wunused-but-set-parameter since gcc 4.6, though the few warnings I've seen from it were all false positives.
https://gcc.gnu.org/onlinedocs/gcc-4.6.0/gcc/Warning-Options.html
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
This change fixes the following -Wunused-but-set-parameter warning:
netwerk/test/fuzz/FuzzingStreamListener.cpp:18:49: warning: parameter 'aOffset' set but not used [-Wunused-but-set-parameter]
|
|
Assignee | |
Comment 2•3 years ago
|
||
But don't enable on gcc because it reports false positives, such as:
js/src/jsapi-tests/testJitABIcalls.cpp:445:61: warning: parameter 'lineno' set but not used [-Wunused-but-set-parameter]
js/src/jsapi-tests/testJitABIcalls.cpp:461:56: warning: parameter 'base' set but not used [-Wunused-but-set-parameter]
Even though those parameters are used here:
https://searchfox.org/mozilla-central/source/js/src/jsapi-tests/testJitABIcalls.cpp#445,450,461,464
Depends on D129350
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a9ec3b454039
https://hg.mozilla.org/mozilla-central/rev/9a7479044bb4
|
||
Comment 5•3 years ago
|
||
Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.
|
||
Updated•3 years ago
|
Description
•