Account setup: `Get a new email address` randomly shown/hidden while entering email address, shaking UI
Categories
(Thunderbird :: Account Manager, defect, P5)
Tracking
(thunderbird_esr91 wontfix, thunderbird96 wontfix)
People
(Reporter: thomas8, Assigned: aleca)
References
Details
(Keywords: polish)
Attachments
(2 files)
Just a nit to polish.
I've always been wondering why account setup feels so shaky - until I had a closer look.
We're constantly checking the email address entered for validity, and if it's valid, we hide the Get a new email address
link. Unfortunately, the validity of an email address changes several times as you type it, in turn causing that link to play hide and seek and shake up all of the UI underneath (see screencast above). Not a good first impression, and useless, too - when you enter an email here, meaning you already have one, so we don't and we wouldn't want to use that email for the new email wizard.
Expected:
- no link flicker
- no UI shakeup
- just hide the link as soon as the email field is no longer empty
Comment 1•3 years ago
|
||
I guess there's a case to be made for just never hiding the link as well.
Assignee | ||
Comment 2•3 years ago
|
||
I guess there's a case to be made for just never hiding the link as well.
We shouldn't do this as it will create problems with visually impaired users, adding an extra and unexpected keyboard navigation stop rather than quickly jumping from the email field to the password field.
To fix this we should:
- Implement a better email address validation method that doesn't return true for cases like
name@
. Right now we're using the built-in HTML5 form validity and it's not the best. - Update the styling to guarantee a no-flicker hide/show action for that link. This can be achieved with some proper padding and margin updates.
Comment 3•3 years ago
|
||
Well, the validation isn't the problem: name@ isn't valid, and the validator agrees. name@x is theoretically valid, so I agree with Thomas it's just a matter of checking if the field is empty or not. If you want to hide.
But, how is the visually impaired user supposed to get to the "get a new email address" link if you hide it? They would not move as far down on the page without filling the email field, and then it would be too late as it's gone already. This is different from how users in general would see it: for them it's more of a contextual ad and quite a natural spot to place it.
Assignee | ||
Comment 4•3 years ago
|
||
Well, the validation isn't the problem: name@ isn't valid, and the validator agrees. name@x is theoretically valid
Ah, my bad, I misspoke.
But, how is the visually impaired user supposed to get to the "get a new email address" link if you hide it?
That's a whole other issue not related to this bug, but to the way we offer that link in that position and at that stage, which is somewhat awkward.
Regardless, if the user is typing an email in that field, keeping that link that interferes with the focus steps of the form doesn't make sense.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 5•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/8648109ac749
Hide provisioner link in account setup if email field has value. r=mkmelin
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Description
•