Closed Bug 1733638 Opened 3 years ago Closed 3 years ago

Fallback timestamp tooltip not shown on chat messages

Categories

(Thunderbird :: Instant Messaging, defect)

Thunderbird 91
defect

Tracking

(thunderbird_esr91+ fixed, thunderbird94+ fixed)

RESOLVED FIXED
95 Branch
Tracking Status
thunderbird_esr91 + fixed
thunderbird94 + fixed

People

(Reporter: freaktechnik, Assigned: freaktechnik)

References

Details

Attachments

(1 file)

When we don't show a nick/conversation rich tooltip we used to show the timestamp of the message (or whatever title some of the html content of the message may have set).

It appears this broke because we can no longer fall back to the default aHTMLTooltip by just setting a title and not showing our tooltip.

Blocks: tb91found
Target Milestone: --- → 95 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/2ac786cc5fa2
Fix chat conversation timestamp tooltips. r=clokep

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

Comment on attachment 9243956 [details]
Bug 1733638 - Fix chat conversation timestamp tooltips. r=clokep

[Approval Request Comment]
Regression caused by (bug #): probably some e10s bug that changed how tooltips work
User impact if declined: Can't get the exact timestamp for a message depending on their chat theme
Testing completed (on c-c, etc.): Has a mochitest, tested on c-c
Risk to taking this patch (and alternatives if risky): Changes logic for the chat tooltip, so would at most affect chat tooltips.

Attachment #9243956 - Flags: approval-comm-beta?

Comment on attachment 9243956 [details]
Bug 1733638 - Fix chat conversation timestamp tooltips. r=clokep

[Triage Comment]
Approved for beta

Attachment #9243956 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9243956 [details]
Bug 1733638 - Fix chat conversation timestamp tooltips. r=clokep

[Approval Request Comment]
Regression caused by (bug #): not determined, probably from around the time of the e10s conversion
User impact if declined: Can not get exact time of a message in some chat themes
Testing completed (on c-c, etc.): c-c, beta, automated test, applies to esr
Risk to taking this patch (and alternatives if risky): should not affect any other features

Attachment #9243956 - Flags: approval-comm-esr91?

Comment on attachment 9243956 [details]
Bug 1733638 - Fix chat conversation timestamp tooltips. r=clokep

[Triage Comment]
Approved for esr91

Attachment #9243956 - Flags: approval-comm-esr91? → approval-comm-esr91+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: