Closed Bug 1733851 Opened 3 years ago Closed 3 years ago

Don't import `ExtensionManager` in extensions tests

Categories

(WebExtensions :: General, task, P3)

task

Tracking

(firefox95 fixed)

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: mathew.hodson, Assigned: mathew.hodson)

References

Details

Attachments

(1 file)

In https://phabricator.services.mozilla.com/D118569#4015156, @robwu wrote:

Do not export ExtensionManager. Could you create a new patch or bug to take care of removing it? It's not as trivial as exporting it, and I'd like to have a minimal patch for such a refactor.

ExtensionManager is used in two tests:

Its use is basically ExtensionManager.extensions.get(extensionId);
That can be replaced with a call to ExtensionProcessScript.getExtensionChild(extensionId);

Blocks: 1531368
Assignee: nobody → mathew.hodson
Summary: Don't depend on ExtensionManager in extensions tests → Don't import ExtensionManager in extensions tests
Summary: Don't import ExtensionManager in extensions tests → Don't import `ExtensionManager` in extensions tests
Attachment #9244112 - Attachment description: Bug 1733851 - Don't depend on ExtensionManager in extensions tests. r?robwu → Bug 1733851 - Don't import `ExtensionManager` in extensions tests. r?robwu
Attachment #9244112 - Attachment is obsolete: true
Attachment #9244112 - Attachment is obsolete: false

Changing severity to N/A because this is a task.

Severity: -- → N/A
Priority: -- → P3

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mathew.hodson, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(rob)
Flags: needinfo?(mathew.hodson)

The patch stack appears to be blocked on review from someone else.

To avoid bitrot, I suggest to split off the SubprocessImpl changes to a separate patch and land everything at once @mathew, as suggested at https://phabricator.services.mozilla.com/D118569#4155831

Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(rob)
Flags: needinfo?(mathew.hodson)

I don't have access to land patches. Can you land the first four patches in the stack?

I will work on splitting up the last patch that hasn't been approved.

Flags: needinfo?(rob)

I've pushed to land.

Flags: needinfo?(rob)
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/294465905b58 Don't import `ExtensionManager` in extensions tests. r=robwu
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: