Don't import `ExtensionManager` in extensions tests
Categories
(WebExtensions :: General, task, P3)
Tracking
(firefox95 fixed)
Tracking | Status | |
---|---|---|
firefox95 | --- | fixed |
People
(Reporter: mathew.hodson, Assigned: mathew.hodson)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
In https://phabricator.services.mozilla.com/D118569#4015156, @robwu wrote:
Do not export
ExtensionManager
. Could you create a new patch or bug to take care of removing it? It's not as trivial as exporting it, and I'd like to have a minimal patch for such a refactor.
ExtensionManager
is used in two tests:
- https://searchfox.org/mozilla-central/source/toolkit/components/extensions/test/mochitest/test_ext_contentscript_cache.html
- https://searchfox.org/mozilla-central/source/toolkit/components/extensions/test/xpcshell/test_ext_schemas_interactive.js
Its use is basically
ExtensionManager.extensions.get(extensionId);
That can be replaced with a call toExtensionProcessScript.getExtensionChild(extensionId);
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 2•3 years ago
|
||
Changing severity to N/A because this is a task.
Comment 3•3 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mathew.hodson, could you have a look please?
For more information, please visit auto_nag documentation.
Comment 4•3 years ago
|
||
The patch stack appears to be blocked on review from someone else.
To avoid bitrot, I suggest to split off the SubprocessImpl changes to a separate patch and land everything at once @mathew, as suggested at https://phabricator.services.mozilla.com/D118569#4155831
Assignee | ||
Comment 5•3 years ago
|
||
I don't have access to land patches. Can you land the first four patches in the stack?
I will work on splitting up the last patch that hasn't been approved.
Comment 8•3 years ago
|
||
bugherder |
Description
•