Urlbar search mode indicator invisible in HCM when the urlbar is not focused
Categories
(Firefox :: Address Bar, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox-esr91 | --- | unaffected |
firefox93 | --- | unaffected |
firefox94 | + | verified |
firefox95 | --- | verified |
People
(Reporter: itiel_yn8, Assigned: bugzilla)
References
(Regression)
Details
(Keywords: access, regression, Whiteboard: [fidefe-theme][hcm-2021-h2])
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
Tested on Windows with HCM White.
Comment 1•3 years ago
|
||
Reproduced on HCM when the address bar dropdown panel is opened and search mode chiclet is selected.
When the dropdown is dismissed with Escape
key, the chiclet won't be visible. If the focus is moved in-page, the chiclet will become visible.
Mozregression returned Bug 1730237 - Split --urlbar-box-focus-bgcolor out from --urlbar-box-bgcolor. r=desktop-theme-reviewers,dao
as regressor, Harry could you please take a look? Thank you!
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
[Tracking Requested - why for this release]:
UI element is invisible in HCM. Low-risk, CSS-only fix is possible.
Assignee | ||
Comment 3•3 years ago
|
||
This patch unifies the HCM colors used in the identity box, the search mode indicator, and the zoom indicator. It uses the HCM convention used in VS Code of using dotted and solid offset outlines to show hover and active states.
Assignee | ||
Comment 4•3 years ago
|
||
Morgan, the attached patch adds a dotted inset outline on an element to denote focus in HCM. The outline becomes solid on :hover:active. I've seen that done in VS Code and it was the best model I could think of here, given the element uses a vibrant background color. What do you think? Is there a better way to show hover/active?
Updated•3 years ago
|
Comment 5•3 years ago
|
||
(In reply to Harry Twyford [:harry] from comment #4)
Morgan, the attached patch adds a dotted inset outline on an element to denote focus in HCM. The outline becomes solid on :hover:active. I've seen that done in VS Code and it was the best model I could think of here, given the element uses a vibrant background color. What do you think? Is there a better way to show hover/active?
Thanks for patching this! I'm gonna give it a spin on Windows in a few different HCM themes, and then I'll follow up here with thoughts :)
Updated•3 years ago
|
Updated•3 years ago
|
Comment 8•3 years ago
|
||
bugherder |
Assignee | ||
Comment 9•3 years ago
|
||
Comment on attachment 9245928 [details]
Bug 1735643 - Unify Urlbar box HCM behaviour. r?#desktop-theme-reviewers!
Beta/Release Uplift Approval Request
- User impact if declined: The search mode indicator in the Urlbar will be invisible in HCM.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): CSS-only, well-understood.
- String changes made/needed:
Comment 10•3 years ago
|
||
Comment on attachment 9245928 [details]
Bug 1735643 - Unify Urlbar box HCM behaviour. r?#desktop-theme-reviewers!
Approved for 94.0b9.
Comment 11•3 years ago
|
||
bugherder uplift |
Updated•3 years ago
|
Comment 12•3 years ago
|
||
I've managed to reproduce the issue using Fx95.0a1.
The issue is verified fixed using Fx95.0b5 and latest Fx96.0a1 on Windows 10, Ubuntu 20.04 and macOS 11. The one-off ciclet is correctly visible with high contrast mode enabled.
Updated•1 year ago
|
Description
•