Closed
Bug 1737054
Opened 3 years ago
Closed 3 years ago
HCM hover state on shield/lock does not match page actions
Categories
(Firefox :: Address Bar, defect, P2)
Firefox
Address Bar
Tracking
()
People
(Reporter: bugzilla, Assigned: lesore0789, Mentored)
References
Details
(Keywords: access, good-first-bug, Whiteboard: [lang=css][hcm-2021-h2])
Attachments
(2 files)
As of bug 1735643, the Urlbar page actions invert their colors when hovered in High Contrast Mode. Specifically, they use SelectedItem
/SelectedItemText
for their colours. The shield and lock icon don't yet use those colors on hover.
Reporter | ||
Comment 1•3 years ago
|
||
These two lines should be replaced with
background-color: var(--urlbar-box-hover-bgcolor);
color: var(--urlbar-box-hover-text-color);
and
background-color: var(--urlbar-box-active-bgcolor);
color: var(--urlbar-box-hover-text-color);
respectively. See the patch in bug 1735643 for examples of similar changes.
Updated•3 years ago
|
Assignee: nobody → lesore0789
Status: NEW → ASSIGNED
Hi harry if you don't mind helping with more details i would love to work on this
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b08b5e664b36
HCM hover state on shield/lock does not match page actions. r=harry,desktop-theme-reviewers
Comment 5•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox95:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
Comment 6•3 years ago
|
||
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ac27da59cf34
add missing semicolon. r=harry
Comment 8•3 years ago
|
||
bugherder |
Comment 9•3 years ago
|
||
The issue is verified fixed using the latest Fx98.0a1 and Fx97.0b1 on Windows 10 and Ubuntu 20.04. The shield and lock buttons have the correct hover color in high contrast mode.
Updated•1 year ago
|
Accessibility Severity: --- → s3
Whiteboard: [lang=css][access-s3][hcm-2021-h2] → [lang=css][hcm-2021-h2]
You need to log in
before you can comment on or make changes to this bug.
Description
•