Closed
Bug 1739061
Opened 3 years ago
Closed 3 years ago
Remove skip-if=!fission annotation on context selector tests
Categories
(DevTools :: Console, task)
DevTools
Console
Tracking
(Fission Milestone:Future, firefox-esr91 wontfix, firefox94 wontfix, firefox95 wontfix, firefox96 fixed)
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
(Whiteboard: dt-perf-stability-mvp)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This test should pass either with Fission or EFT, so it's probably better to not skip them, and use todo to handle the cases when the tests should not pass
|
Assignee | |
Comment 1•3 years ago
|
||
Those tests are passing with Fission enabled, as well as with EFT enabled.
it would be better to not skip them, so we remove the annotation, and use todo
to handle cases where the tests shouldn't pass.
Depends on D130180
|
||
Updated•3 years ago
|
Fission Milestone: --- → Future
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/24c1a120bb77
[devtools] Remove skip-if annotation on console context selector tests. r=ochameau.
|
||
Comment 3•3 years ago
|
||
Backed out for causing mochitest failures on browser_resources_document_events.js
Flags: needinfo?(nchevobbe)
|
|
Assignee | |
Comment 4•3 years ago
|
||
fixed the test and pushed again: https://treeherder.mozilla.org/jobs?repo=try&revision=8fb76044382d969713375e964b710312cb42de3c
Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5ae8cb91f3e1
[devtools] Remove skip-if annotation on console context selector tests. r=ochameau.
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox96:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
|
||
Comment 7•3 years ago
|
||
Setting status-firefox95=wontfix because we don't need to uplift this test fix to Beta 95.
You need to log in
before you can comment on or make changes to this bug.
Description
•