Follow-up to bug 1729314 (Attachment bar is not accessible): Use the html splitter between the compose browser and attachment area
Categories
(Thunderbird :: Message Compose Window, task)
Tracking
(thunderbird_esr91 wontfix)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr91 | --- | wontfix |
People
(Reporter: newsfan, Assigned: henry-x)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fixed by bug 1720348])
+++ This bug was initially created as a clone of Bug #1729314 +++
See bug 1729314 comment #6 and bug 1729314 comment #7:
A XUL splitter placed between two XUL "boxes" may not work as desired.
https://hg.mozilla.org/comm-central/rev/59c602cfd601#l2.28
There is already a custom element for this mail/base/content/widgets/pane-splitter.js.
The height calculation https://hg.mozilla.org/comm-central/rev/59c602cfd601#l1.42 is unfortunate since layout is typically a task of the CSS layout system.
And wouldn't flexing the <html:details> work with CSS display: contents? Maybe some inspiration in some of these articles:
https://www.google.com.au/search?q=html+details+flex+contents
|
Assignee | |
Comment 1•3 years ago
|
||
(In reply to newsfan from comment #0)
+++ This bug was initially created as a clone of Bug #1729314 +++
See bug 1729314 comment #6 and bug 1729314 comment #7:
A XUL splitter placed between two XUL "boxes" may not work as desired.
https://hg.mozilla.org/comm-central/rev/59c602cfd601#l2.28
There is already a custom element for this mail/base/content/widgets/pane-splitter.js.The height calculation https://hg.mozilla.org/comm-central/rev/59c602cfd601#l1.42 is unfortunate since layout is typically a task of the CSS layout system.
And wouldn't flexing the <html:details> work with CSS display: contents? Maybe some inspiration in some of these articles:
https://www.google.com.au/search?q=html+details+flex+contents
Sorry, I missed this bug before I opened 1741368. The plan was to eventually use the html splitter, but it wasn't available when I wrote the patch. But bug 1729386 has since added it, and your comment reminded me that I was meant to revise this.
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 3•3 years ago
|
||
@aleca, if you are considering adding the option to place the attachment list in an inline-end column, note that I'm going to be working on this bug soon. Switching the splitter from vertical to horizontal should be easier after this. I'll also keep your idea in the back of my mind when I go back through the code.
needinfo-ing you just so you see the message.
|
||
Comment 4•3 years ago
|
||
Sounds good, thanks for the heads up.
Indeed, switching the splitter from vertical to horizontal should be trivial.
|
|
Assignee | |
Comment 5•3 years ago
|
||
Fixed in bug 1720348
|
||
Updated•3 years ago
|
Description
•