Closed Bug 1729386 Opened 3 years ago Closed 3 years ago

Create a splitter custom element

Categories

(Thunderbird :: Mail Window Front End, enhancement)

enhancement

Tracking

(thunderbird_esr91 unaffected)

RESOLVED FIXED
95 Branch
Tracking Status
thunderbird_esr91 --- unaffected

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We use splitters all over the place, this bug is about creating them as an HTML custom element for use in the 3-pane and address book tabs.

Attachment #9239737 - Attachment description: WIP: Bug 1729386 - Create a splitter custom element → Bug 1729386 - Create a splitter custom element. r=mkmelin

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/0a6aa6aabf74
Create a splitter custom element. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

(In reply to Geoff Lankow (:darktrojan) from comment #0)

We use splitters all over the place, this bug is about creating them as an HTML custom element for use in the 3-pane and address book tabs.

Since you're only mentioning 3-pane and AB, what's needed to also use this in composition window?

Flags: needinfo?(geoff)

Generally speaking, the main problem is that parent element has to be display: grid, and possibly has to be HTML (I've never tried it with a XUL element). Some other work needs to be done to set up things like remembering the size.

I see there are three splitters in the compose window. The sidebar splitter would be straightforward. The other two are children of the same element, and that might be problematic. I don't know how well that would work.

Side note: I've been doing a lot of work on upgrading the splitter that landed in this bug, and will file a new bug about it soon.

Flags: needinfo?(geoff)

I'm planning on using this splitter in bug 1741361 (within the compose window). Are there any planned changes that I should wait for?

Also, it would be nice to make these focusable with keyboard controls and properly set aria-valuenow and aria-orientation attributes (https://www.w3.org/TR/wai-aria-1.1/#separator). I wouldn't mind doing this myself, but I don't want to step on any other changes, so please CC me.

Flags: needinfo?(geoff)

No, I've finished everything I had planned (in bug 1744657).

Flags: needinfo?(geoff)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: