Closed
Bug 1746785
Opened 3 years ago
Closed 3 years ago
Fix rust 1.57 Windows linking for SeaMonkey 2.53
Categories
(SeaMonkey :: Build Config, task)
Tracking
(seamonkey2.53+ fixed)
RESOLVED
FIXED
seamonkey2.53
People
(Reporter: frg, Assigned: frg)
References
Details
(Whiteboard: SM2.53.10.2)
Attachments
(1 file)
|
(deleted),
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
rust 1.57's libstd adds a dependency on bcrypt on Windows. Linking libxul fails for latest 2.53 under Windows because of it. comm-central builds are not affected because they are so bloated and get the reference from somewhere else already by chance. Bug 1736486 fixes it for Spidermonkey builds but we need it for the main project build too in 2.53.
|
Assignee | |
Comment 1•3 years ago
|
||
Patch Bill did and we tested together. We decided against a specific 1.57 version check. Not needed and soon we will require the new version anyway.
Baiscally 2.53 only for now but might be needed in 2.57 later so r/a+ from me for it too.
Attachment #9256070 -
Flags: review+
Attachment #9256070 -
Flags: approval-comm-release+
Attachment #9256070 -
Flags: approval-comm-esr60+
|
|
Assignee | |
Comment 2•3 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/5f0aacc316d0f170321a4583c2b1b7db6fd557d5
Link bcrypt where needed. r=frg a=frg
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.53
You need to log in
before you can comment on or make changes to this bug.
Description
•