Closed Bug 1747400 Opened 3 years ago Closed 2 years ago

"Options" top bar is not functional on saloncentric.com with ETP - Strict enabled

Categories

(Core :: Privacy: Anti-Tracking, defect, P3)

Firefox 97
ARM64
Android
defect

Tracking

()

RESOLVED FIXED
103 Branch
Tracking Status
firefox97 --- wontfix
firefox103 --- fixed

People

(Reporter: oanaarbuzov, Assigned: twisniewski)

References

(Blocks 1 open bug, )

Details

Attachments

(2 files)

Attached image StrictVSStandard.png (deleted) —

Environment:
Browser / Version: Firefox Nightly 97.0a1 (🦎 97.0a1-20211221093038)
Operating System: Google Pixel 5 (Android 12) - 1080 x 2340 pixels, 19.5:9 ratio (~432 ppi density), Samsung Galaxy S8 (Android 9) - 1440 x 2960 pixels, 18.5:9 ratio (~570 ppi density)

Prerequisites:
ETP - Strict enabled.

Steps to reproduce:

  1. Navigate to https://www.saloncentric.com/deals?prefn1=dimBrand&prefv1=Sam%20Villa
  2. Tap "Search" button.
  3. Observe behavior.

Expected Behavior:
"Search" is triggered.

Actual Behavior:
Nothing happens, "Search" button is not functional.

Notes:

  1. The issue is also reproducible for "Browse" menu and "Account" button and the top options bar overlaps top part of the sites (and can't be scrolled).
  2. The issue is not reproducible with ETP - Standard.
  3. Screenshot attached.
Severity: -- → S3

I see this in the console:

Uncaught TypeError: can't access property "length", o is undefined
    RICHRELEVANCE https://www.saloncentric.com/on/demandware.static/Sites-saloncentric-us-Site/-/en_US/v1651207256834

So this is related to Rich Relevance. Our shim is treating the value RR.data.JSON incorrectly, as the site expects there to be an array RR.data.JSON.placements, and the site's search works fine if we make that an empty array. So it's worth doing that.

Assignee: nobody → twisniewski
Status: NEW → ASSIGNED
Pushed by twisniewski@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5579801f7ed2 Update the value SmartBlock's Rich Relevance shim returns for RR.data.JSON to better-match what websites expect; r=ksenia,webcompat-reviewers
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
Blocks: 1773100
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: