I noticed that some elements in the site identity and permissions panels have dotted focus rings whereas most elements have a thicker solid one. Also panelUI.inc.css defines a custom box-shadow to re-implement the solid focus ring; it should use the predefined outline instead.

https://hg.mozilla.org/mozilla-central/rev/9fb2cc3d0aae

I can still find some inconsistencies while verifying the fix using latest Nightly 98.0a1 on macOS 10.15.

1. In the Tracking Protection panel, the focus on the "Site not working?" hyperlink is different from the other elements. The focus there uses the colors from the system. The same think can be seen in the Notification panel, the focus from "Learn more" hyperlink is different.

2. In some panels, for example de Download panel, some elements have focus rings, other don't. Also, the color of the focus rings is from the system.

3. In some panels the focus ring it's accompanied by a highlight, but in others the highlight is not there. For example, in the Download panel there is a highlight, but in the Protection Panel there is none.

4. In the Bookmarks panel, the one that can be customized on the Toolbar, there is no focus ring.

Are these results expected?

(In reply to Oana Botisan, Desktop Release QA from comment #4)

4. In the Bookmarks panel, the one that can be customized on the Toolbar, there is no focus ring.

Are these results expected?

Since the bookmarks toolbar button opens a places menupopup it's not really a panel. So keying into one of the bookmark menuitems adds attribute _moz-menuactive which is the same as if it was moused over. I was working on a patch to convert that bookmarks menu into a panel a while ago, but it handles giant bookmarks containers a lot worse. Like if there are 1000 bookmarks in a folder, the interactions and animations kinda stutter.

Alright... let's forget about the 4th point, but how about the other three?

(In reply to Oana Botisan, Desktop Release QA from comment #4)

I can still find some inconsistencies while verifying the fix using latest Nightly 98.0a1 on macOS 10.15.

1. In the Tracking Protection panel, the focus on the "Site not working?" hyperlink is different from the other elements. The focus there uses the colors from the system. The same think can be seen in the Notification panel, the focus from "Learn more" hyperlink is different.

2. In some panels, for example de Download panel, some elements have focus rings, other don't. Also, the color of the focus rings is from the system.

3. In some panels the focus ring it's accompanied by a highlight, but in others the highlight is not there. For example, in the Download panel there is a highlight, but in the Protection Panel there is none.

(In reply to Oana Botisan, Desktop Release QA from comment #6)

Alright... let's forget about the 4th point, but how about the other three?

I can probably work on the other 3 this weekend. I'll bookmark this and try to find the issues. I have definitely noticed a higher density of focus related issues in the downloads panel, although I can't clearly remember the specifics. If you remember any other details, let me know? Thanks

(In reply to Oana Botisan, Desktop Release QA from comment #4)

I can still find some inconsistencies while verifying the fix using latest Nightly 98.0a1 on macOS 10.15.

That's somewhat expected. This bug was meant to make some things more consistent but there's clearly more work to do.

1. In the Tracking Protection panel, the focus on the "Site not working?" hyperlink is different from the other elements. The focus there uses the colors from the system. The same think can be seen in the Notification panel, the focus from "Learn more" hyperlink is different.

I've updated the link styling in bug 1755665.

2. In some panels, for example de Download panel, some elements have focus rings, other don't. Also, the color of the focus rings is from the system.

3. In some panels the focus ring it's accompanied by a highlight, but in others the highlight is not there. For example, in the Download panel there is a highlight, but in the Protection Panel there is none.

Please file followup bugs on these. Thanks!

(In reply to Dão Gottwald [::dao] from comment #8)

2. In some panels, for example de Download panel, some elements have focus rings, other don't. Also, the color of the focus rings is from the system.

3. In some panels the focus ring it's accompanied by a highlight, but in others the highlight is not there. For example, in the Download panel there is a highlight, but in the Protection Panel there is none.

Please file followup bugs on these. Thanks!

I filed bug 1756002 to keep track of fixes that have landed as well as outstanding issues.

I filled bug 1756112 and bug 1756113 for the remaining issues. I will mark this issue as verified fix and the other issues can be followed up in the bugs mentioned.