Better support orientation.lock('natural')
Categories
(GeckoView :: General, defect, P2)
Tracking
(firefox110 fixed)
| Tracking | Status | |
|---|---|---|
| firefox110 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
References
(Blocks 1 open bug)
Details
(Whiteboard: [geckoview:m98] [geckoview:2022h2?])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
natural is defined as (from https://w3c.github.io/screen-orientation/#dfn-natural)
Natural is an orientation that refers to either portrait-primary or landscape-primary depending on the device's usual orientation. This orientation is usually provided by the underlying operating system.
Actually, GeckoView maps it as (https://searchfox.org/mozilla-central/rev/afbff3f3ae087181d9988fe19e09cc15927fb7ff/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntime.java#874-875
)
} else if (geckoOrientation == ScreenOrientation.DEFAULT.value) {
return ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED;
SCREEN_ORIENTATION_UNSPECIFIED seems to mean unlock, so it isn't correct. So we should use better orientation type in GeckoView implement. or set landscape/portrait on natural in DOM side.
Also, Chromium considers this well.
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
||
Updated•2 years ago
|
|
|
||
Comment 1•2 years ago
|
||
Assigning this bug to Makoto. He will decide whether we need to prioritize it for 2022 H2.
|
Assignee | |
Comment 2•2 years ago
|
||
natural is defined as (from https://w3c.github.io/screen-orientation/#dfn-natural)
A computer monitor are commonly naturally landscape-primary, while a mobile
phones are commonly naturally portrait-primary.
But GeckoView sets SCREEN_ORIENTATION_UNSPECIFIED that is unlock orientation.
Like Blink, we should set landscape-primary or portrait-primary (depends on
current monitor).
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Description
•