Move selectors from reducers modules to selectors modules
Categories
(DevTools :: Debugger, task)
Tracking
(firefox98 fixed)
| Tracking | Status | |
|---|---|---|
| firefox98 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Currently, debugger's reducer modules are hosting many selector methods which are directly used by the React Components.
For example all these methods of the sources reducer:
https://searchfox.org/mozilla-central/rev/d4b9c457db637fde655592d9e2048939b7ab2854/devtools/client/debugger/src/reducers/sources.js#583-1036
It would probably help the long term maintenance of this by having a clearer split between:
- reducers, which only implement the
updatemethod - selectors, which are querying the state with a particular layout for the queried data
Doing this might actually help revisit the selectors and improve their performance.
This would probably help highlight the number of selectors used, their inter-dependencies and help craft selectors that memoize more frequently.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 3•3 years ago
|
||
try run with all the patches:
https://treeherder.mozilla.org/jobs?repo=try&revision=6a9f97bfd8654052d3b99618ee6627b36f91275f
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/22568bcf2d59
https://hg.mozilla.org/mozilla-central/rev/4c536f66f404
Description
•