Closed Bug 1751299 Opened 3 years ago Closed 3 years ago

When opening the new Address Book tab, search box should helpfully have focus

Categories

(Thunderbird :: Address Book, enhancement, P3)

enhancement

Tracking

(thunderbird_esr91 wontfix)

VERIFIED FIXED
100 Branch
Tracking Status
thunderbird_esr91 --- wontfix

People

(Reporter: thomas8, Assigned: eghbalniakian)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, ux-efficiency)

Attachments

(1 file)

98.0a1 (2022-01-20) (64-bit), Win10

STR

  1. Open new Address Book
  2. Check where the focus is
  3. Try to move focus to search field for searching addresses

Actual

  • No visible focus
  • It takes as many as 12 Tab keypresses to reach the searchbox.
  • No shortcut either (I've filed that separately as bug 1751304).

Expected

  • Initial focus after opening AB should be on search box, as the most likely action after opening the main AB is searching for contacts
  • It's a convenient central focus position where the AB list or the contacts list are easy to reach.
No longer blocks: tb-new-addrbook
Assignee: nobody → eghbalniakian
Status: NEW → ASSIGNED

Hi Kian, thank you for picking this up among your first handful of patches! :-))

np

Hi Kian, would you like to do the final touches on this yourself so that we can land it? See my comment on phabricator.

Flags: needinfo?(eghbalniakian)

Kian replied here:

I will run the linter and update the revision. Thank you for reminding me.

I think everything is fixed.

Flags: needinfo?(eghbalniakian)
Target Milestone: --- → 100 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/2a24605bc395
When opening the new Address Book tab, search box should helpfully have focus r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

(In reply to Kian from comment #7)

I think everything is fixed.

Awesome! Thank you Kian for implementing this helpful change!

Verified: working as expected on 100.0a1 (2022-03-22) (64-bit), Win10.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: