Enter does not trigger default action button (`Save`) when editing contact in new Address Book (highly inconvenient for keyboard dependent users)
Categories
(Thunderbird :: Address Book, defect, P2)
Tracking
(thunderbird_esr91 unaffected)
Tracking | Status | |
---|---|---|
thunderbird_esr91 | --- | unaffected |
People
(Reporter: thomas8, Assigned: darktrojan)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Keywords: access, regression, ux-efficiency)
Attachments
(2 files, 1 obsolete file)
+++ This bug was initially created as a clone of Bug #1751978 +++
Seen in 98.0a1 (2022-01-25) (64-bit), Win10
STR:
- Edit a contact in ("new") Address Book
- Fill First, Last, Email address
- Press
Enter
with focus in Email address input to trigger the default button (Save
) - Try to save the contact using keyboard only (!)
Actual results:
- Pressing
Enter
does nothing. - Saving the contact via keyboard requires pressing
Tab
key as many as 32 (!) times.
Expected results:
- Pressing
Enter
from any input should triggerSave
default button as it used to - that's how default buttons work in dialogs, and this is essentially still a modal dialog as Magnus correctly pointed out. - In addition, explore restoring an access key for pressing
Save
button (well, that's another can of worms, just listed here for contextual completeness).
Reporter | ||
Comment 1•3 years ago
|
||
For keyboard depending users like the blind, this will be living hell, hence S2/P2.
Reporter | ||
Comment 2•3 years ago
|
||
(In reply to Thomas D. (:thomas8) from comment #1)
For keyboard depending users like the blind, this will be living hell, hence S2/P2.
Update: Keyboard dependent users will have to press the Tab
key as many as 32 (!) times starting from email field. I initially miscounted.
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Comment 3•3 years ago
|
||
I think the fields should be within a <form> so that normal "submit" logic applies.
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 4•3 years ago
|
||
I have a patch underway for this and bug 1752051, if you haven't started yet.
Comment 5•3 years ago
|
||
Comment 6•3 years ago
|
||
Adding what I had. Working but some things to sort out wrt how "New Contact" works while editing. In the patch I would disable that while editing since it's rather confusing what one gets... but I saw one of your other patches might have taken care of this now.
We really should get bug 1562198 fixed. At the moment we kind of allow saving invalid values. Or not really, but the UI implies we would, e.g. an invalid email will "save" without warning, but will not really be saved.
Assignee | ||
Comment 7•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/46027db2eff2
Make Address Book card editor a form. r=aleca
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 9•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Comment 10•3 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/7fe1ddf94e9b
Prompt to save AB contacts when clicking the cancel button as well. r=aleca
Updated•3 years ago
|
Comment 11•3 years ago
|
||
Thanks for this. Confirm that both esc and enter work on Windows with 99 beta. And there is a prompt when cancelling if data has changed.
Description
•