Closed
Bug 17524
Opened 25 years ago
Closed 24 years ago
context menu on links has "Bookmark this page"
Categories
(SeaMonkey :: General, defect, P3)
SeaMonkey
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: dbaron, Assigned: law)
References
Details
(Whiteboard: [nsbeta3+])
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
DESCRIPTION: If you right click on a link, the context menu has "Bookmark this page", which adds a bookmark to the page being viewed (not the link). It should instead have an "add bookmark to link" item that adds a bookmark to the link. Having the "bookmark this page" item is confusing - I expected it to bookmark the link. STEPS TO REPRODUCE: * load this page in apprunner * right click on a link * choose the bookmark-adding option ACTUAL RESULTS: * the bookmark adding option is called "Bookmark this page" * it adds a bookmark to this page EXPECTED RESULTS: * the bookmark adding option is called "Add bookmark for link" * it bookmarks the link DOES NOT WORK CORRECTLY ON: * Linux, apprunner, 1999-10-28-08-M11 WORKS CORRECTLY ON: * NN 4.61 Linux
Comment 1•25 years ago
|
||
ALSO DOES NOT WORK CORRECTLY ON: Windows NT, mozilla.exe, 1999-10-27-08-M11 binary WORKS CORRECTLY ON: Windows NT, Navigator 4.7 ADDITIONAL INFORMATION: In NN 4.7, the item on the context menu is "Add Bookmark" both when right- clicking on a link and on text/whitespace. The actual bookmark added is correct for both, however.
Updated•25 years ago
|
Assignee: shuang → german
Target Milestone: M16
Comment 2•25 years ago
|
||
german, what should be an easy term for this one? I also re-set the mileston to m16 for later fix.
I am tending towards thinking we need both. The link is added when you are over a link and the page or frame will be added when you're not. I agree with your wording concerns. Right now I believe only Bookmark This Page is implimented anyway. We'll look at this a bit later.
How about 'Bookmark This Page' and 'Bookmark This Link'. cc'ing verah who is owning instructional media and help for the browser.
Updated•25 years ago
|
QA Contact: claudius → sairuh
Summary: [4.xP]context menu on links has "Bookmark this page" → [4.xP] context menu on links has "Bookmark this page"
Comment 5•25 years ago
|
||
spam: reassigning QA contact to self.
Comment 6•25 years ago
|
||
I think German's proposed wording is fine. However, at some point I'd like to look at the entire context menu for this, because in 4.x versions there are several items (Add Bookmark, Create Shortcut, Save Link As.., and Copy Link Location) and its difficult to figure out which does what.
Updated•25 years ago
|
Summary: [4.xP] context menu on links has "Bookmark this page" → context menu on links has "Bookmark this page"
Comment 10•25 years ago
|
||
Moving all UE/UI bugs to new component: User Interface: Design Feedback UE/UI component will be deleted.
Component: UE/UI → User Interface: Design Feedback
Comment 11•25 years ago
|
||
Need to pass this one to engineer to fix/add it. Who is the right person?
Comment 12•25 years ago
|
||
If you re-assign it to Don, and change to no target milestone, we'll look at it on 5/11 and assign it to the right person.
Comment 13•25 years ago
|
||
done.
Assignee: german → don
Status: ASSIGNED → NEW
Target Milestone: M16 → ---
Reporter | ||
Comment 16•24 years ago
|
||
Nominating for nsbeta3, since I think this is an important usability issue.
Keywords: nsbeta3
Assignee | ||
Comment 18•24 years ago
|
||
Assignee | ||
Comment 19•24 years ago
|
||
I've attached a proposed fix. This patch also fixes a couple of other nagging context menu bugs. Note that I do a depth-first recursion of the DOM under the <A> tag, looking for either some text or an alt= attribute on a <IMG> tag to use as the bookmark name. This seems to work reasonably well. Default is to fall back on the URL as the name. I've asked slamm@netscape.com to review.
It would also be cool to use the HTML TITLE attribute of the A element or one of its children, if there is one.
Assignee | ||
Comment 21•24 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 22•24 years ago
|
||
vrfy fixed using opt comm bits. linux/mac, 2000.08.14.12; winnt 2000.08.15.08.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•