Closed Bug 1755197 Opened 3 years ago Closed 3 years ago

Remove breakpoints shifting functionality in the debugger

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(firefox102 fixed)

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: bomsy, Assigned: bomsy)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file, 3 obsolete files)

Breakpoint shifting has been a source of issues in the debugger, especially causing zombie breakpoints issues. We decided to remove this.
Most of the functionality is in syncBreakpoint here https://searchfox.org/mozilla-central/rev/2bdaa395cb841b28f8ef74882a61df5efeedb42b/devtools/client/debugger/src/actions/breakpoints/syncBreakpoint.js#71-168

Assignee: nobody → hmanilla
Status: NEW → ASSIGNED
Attachment #9270216 - Attachment description: Bug 1755197 - [devtools] Add checks for breakpoints on the server in tests → Bug 1755197 - [devtools] Remove server breakpoint on syncing when location in source no longer exists r=ochameau

Comment on attachment 9270216 [details]
Bug 1755197 - [devtools] Remove server breakpoint on syncing when location in source no longer exists r=ochameau

Revision D142545 was moved to bug 1762865. Setting attachment 9270216 [details] to obsolete.

Attachment #9270216 - Attachment is obsolete: true
Attachment #9263654 - Attachment description: Bug 1755197 - [devtools] Remove breakpoint shifting on breakpoint syncing → Bug 1755197 - [devtools] Remove breakpoint shifting on breakpoint syncing r=ochameau

Comment on attachment 9268232 [details]
Bug 1755197 - [devtools] Cleanup up remaping breakpoints

Revision D141341 was moved to bug 1763386. Setting attachment 9268232 [details] to obsolete.

Attachment #9268232 - Attachment is obsolete: true

Comment on attachment 9269370 [details]
Bug 1755197 - [devtools] Add tests for breakpoints in original source whose generated source content changes on reload

Revision D142047 was moved to bug 1764055. Setting attachment 9269370 [details] to obsolete.

Attachment #9269370 - Attachment is obsolete: true
Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e7bc7584f0c2 [devtools] Remove breakpoint shifting on breakpoint syncing r=ochameau
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
Blocks: 1769787
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: