david detects a folder pane performance regression on the trunk. (possibly caused by #172545) the theory (bienvenu is going to verify) is that we are now crossing over to js (see msgMail3PaneWindow.js) for this: + getImageSource: function(row, colID) + { + }, I think only something in phoenix is using that. so my question for hyatt is: should we add a boolean readonly attribute on the view, that you check once in nsTreeBodyFrame, to avoid calling getImageSource(), if the nsIXULTemplateBuilder knows there is not going to be any image source? (in theory the same problem exists in bookmarks.xml, we'd have to fix that, too)

I think we need something better designed. I filed bug 120071 long time ago. Although in that time I thought we need just one listener instead of multiple observers.

I can't tell for sure if this is slowing us down noticeably, but we know that calls into js are expensive, and this causes a lot of them, especially if you're showing 3 or 4 folder columns, so I think we should try to fix this.

Neil and I came to conclusion that we actually don't need getImageSource method at all Phoenix can just use |src="...#Icon"| in its template

Jan: it already does!

No negative personality jokes, please :-)

Comment on attachment 111704 [details] [diff] [review] Proposed patch looks good r=varga you did the right thing, that you didn't backout original patch completely, since it contained other fix for image regions

Comment on attachment 111704 [details] [diff] [review] Proposed patch sr=bienvenu, thx

sr=sspitzer, too. re-assign to neil, set as 1.3 beta

Jan, can you check in the change to browser/ please?

I checked the Phoenix patch in. Marking FIXED

The checked in patch includes a typo that breaks Bookmarks in Phoenix: XML Parsing Error: not well-formed Location: jar:resource:///chrome/browser.jar!/content/ browser/bookmarks/bookmarksTree.xml Line Number 1, Column 2: g<?xml version="1.0"?> -^ ###!!! ASSERTION: An XBL file is malformed. Did you forget the XBL namespace on the bindings tag?: 'Error', file nsXBLService.cpp, line 410 Break: at file nsXBLService.cpp, line 410 Could someone please remove that initial 'g'?

done

*** Bug 184624 has been marked as a duplicate of this bug. ***

Using trunk build 20030228 on winxp, macosx and linux the folder pane loading OK. If there is a specific setup I need to do other than to switch between folders with lots of messages (662 - 3996) then comment with steps and I'll retest this. Verified

Actually the performance affects folder pane painting, e.g. when scrolling.