Closed
Bug 1764236
Opened 3 years ago
Closed 3 years ago
Make copy messages action compatible with virtualized console
Categories
(DevTools :: Console, task)
DevTools
Console
Tracking
(firefox101 fixed)
RESOLVED
FIXED
101 Branch
| Tracking | Status | |
|---|---|---|
| firefox101 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
No description provided.
|
Assignee | |
Comment 1•3 years ago
|
||
This is a naive implementation where we re-create a ConsoleOutput
element, reusing the existing store, and passing a specific prop
so all the messages would be rendered.
In order to include stacktraces, we pass a 0 initial render delay to the
callsites of the SmartTrace component.
We take this as an opportunity to extend the test coverage of SmartTrace around
this feature.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db337e401470
[devtools] Make copy messages action compatible with virtualized console. r=dthayer.
|
||
Comment 3•3 years ago
|
||
Backed out changeset db337e401470 (Bug 1764236) as requested by the dev.
Backout link
Push with failures
Flags: needinfo?(nchevobbe)
|
|
Assignee | |
Comment 4•3 years ago
|
||
mh, looks like there was some hiccups with Phabricator reviewbot, the test is running fine locally. Let's land again
Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8082e637aa56
[devtools] Make copy messages action compatible with virtualized console. r=dthayer.
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox101:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•