Closed Bug 1773879 Opened 2 years ago Closed 2 years ago

"Copy all Messages" does not work in Browser Console

Categories

(DevTools :: Console, defect)

Firefox 101
Desktop
Windows 10
defect

Tracking

(firefox-esr91 unaffected, firefox-esr102103+ fixed, firefox101 wontfix, firefox102 wontfix, firefox103 fixed)

RESOLVED FIXED
103 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 103+ fixed
firefox101 --- wontfix
firefox102 --- wontfix
firefox103 --- fixed

People

(Reporter: alice0775, Assigned: nchevobbe)

References

(Regression)

Details

(Keywords: nightly-community, regression)

Attachments

(1 file)

Steps to reproduce:

  1. Open Browser Console (Ctrl+Shift+J)
  2. Right click on a error(warning) message
  3. Select "Copy all Messages"
  4. Paste to text editor

Actual Results:
Nothing was copied.
An error appears when selecting "Copy all Messages"

TypeError: can't access property "store", toolbox is null context-menu.js:341:42

Expected Results:
All Messages ware copied.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6afa33fe61fdd03767a9dab72be802864f4d1935&tochange=8082e637aa56b75dd24ebc38ed0684036329811c

Has Regression Range: --- → yes
Has STR: --- → yes

:nchevobbe, since you are the author of the regressor, bug 1764236, could you take a look?
For more information, please visit auto_nag documentation.

Flags: needinfo?(nchevobbe)

I have a patch fixing this

Flags: needinfo?(nchevobbe)
Summary: "Copy all Messages" does not work → "Copy all Messages" does not work in Browser Console

We don't have a toolbox in the Browser Console, so we don't
need to have a Provider for its store.
A simple test is added, just checking that the action was
triggered.

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/82da2b52e0b5 [devtools] Fix Copy all Message context menu action in Browser Console. r=jdescottes.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
Flags: needinfo?(nchevobbe)

Nicolas , can this uplift to ESR102?

Blocks: 1777283

Comment on attachment 9281755 [details]
Bug 1773879 - [devtools] Fix Copy all Message context menu action in Browser Console. r=jdescottes.

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Browser Console is used by Firefox engineers and Addon Developers, and we often advertise this feature for people reporting issues
  • User impact if declined: Users can't use the "Copy All Messages" action in the Browser Console
  • Fix Landed on Version: 103
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple couple line fix, only impacting this specific action; covered by an automated test
Flags: needinfo?(nchevobbe)
Attachment #9281755 - Flags: approval-mozilla-esr102?

Comment on attachment 9281755 [details]
Bug 1773879 - [devtools] Fix Copy all Message context menu action in Browser Console. r=jdescottes.

Approved for ESR102.1, thanks.

Attachment #9281755 - Flags: approval-mozilla-esr102? → approval-mozilla-esr102+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: