JS pauses on 'debugger;' when the browser console is open, even if there is no debugger
Categories
(DevTools :: Console, defect, P2)
Tracking
(firefox104 verified)
Tracking | Status | |
---|---|---|
firefox104 | --- | verified |
People
(Reporter: Oriol, Assigned: nchevobbe)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
- Open browser console
- Back in the Firefox window, load this URL in a new tab:
data:text/html,<script>debugger;document.write("OK")</script>
Expected: you see a page with OK
Actual: blank page, the loading indicator still going on
Regression window: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e375b85cfba38ff5f49493d1d48b7561f7f2f8d7&tochange=432e42cbbc4139efd2319952ec33efe8ff9add3c
Seems a potential explanation of bug 1669171, then the culprit would be bug 1657310.
Comment 1•2 years ago
|
||
Bomsy, can you add the relevant meta for browser toolbox and breakpoints
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 2•2 years ago
|
||
stealing this as discussed with bomsy on Slack :)
Assignee | ||
Comment 3•2 years ago
|
||
This patch is sending the doNotAttachThreadActor
property we already set on
some descriptor front to the getWatcher
method, where we then put it on the
session context.
Then in ThreadActor#attach
, if doNotAttachThreadActor
is true, we simply
bail out.
A test is added to check that having a script with a debugger statement does
not lead to the thread pausing.
Updated•2 years ago
|
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c036b48c5be1 [devtools] Don't define empty default values for sessionData in getSessionData. r=ochameau
Comment 5•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Comment 6•2 years ago
|
||
Reproduced with Firefox 101.0a1 (20220423212733) on Windows 10x64 using STR from comment 0. The page is no loaded after opening the browser console.
The issue is verified fixed with Firefox 104.0b4 (20220731190208) on Windows 10x64, macOS 11 and Ubuntu 20.04. The page is successfully loaded while the browser console is opened.
Description
•