Closed Bug 1766523 Opened 3 years ago Closed 3 years ago

Implement new "Super Nova" icons in the Folder Pane

Categories

(Thunderbird :: Theme, task)

Tracking

(Not tracked)

RESOLVED FIXED
102 Branch

People

(Reporter: aleca, Assigned: micah)

References

Details

Attachments

(7 files, 1 obsolete file)

Implement the new icons in the Folder Pane for all accounts.
We need to explore and define if we want these icons to react to the density variations, or if the "compact" variant (16px) should be kept constant.

Keywords: leave-open
Attached file WIP: Bug 1766523 - Supernova folder pane icons (obsolete) (deleted) —
Attachment #9275269 - Attachment is obsolete: true
Attachment #9275359 - Attachment description: Bug 1766523 - new folder pane icons r=aleca → Bug 1766523 - Implement new icons in Folder Pane r=aleca
Status: NEW → ASSIGNED
Target Milestone: --- → 102 Branch

Leaving open because we need to add a density variant for folder pane.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/f66f2d68d50f
Implement new icons in Folder Pane r=aleca

Blocks: 1768670

The icons are incorrectly styled when the treechildren is selected but the tree doesn't have the focus.
This seems to happen only on macOS.
Since these are shadow DOM elements it's kinda tricky to find which style is affecting this in the inspector.
Richard, are you able to figure this out?

Flags: needinfo?(richard.marti)
Flags: needinfo?(richard.marti)

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/58ec8b3b50f9
Show the folder icons correctly in all menulists. r=aleca

(In reply to Alessandro Castellani [:aleca] from comment #6)

Created attachment 9275945 [details]
Screen Shot 2022-05-10 at 1.41.52 PM.png

The icons are incorrectly styled when the treechildren is selected but the tree doesn't have the focus.
This seems to happen only on macOS.
Since these are shadow DOM elements it's kinda tricky to find which style is affecting this in the inspector.
Richard, are you able to figure this out?

There are some places that are missed to set the correct fill/stroke. Found also an issue on Windows with dark theme. I'll look if I can fix the issues.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/b23afa595fe0
Set the correct folder icon colors when selected or new message. r=aleca

Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/1fdf7eea4e4e follow-up - Fix a broken CSS selector. rs=me

I just noticed that the indicator of "new" emails is cut off in normal and compact density.
I think it's a regression but I'm not sure it was caused by the new icon or any adjacent work we did here.
Anyway, it should be a very minor fix.

Flags: needinfo?(micah)
Attached image Windows-new.png (deleted) —

(In reply to Alessandro Castellani [:aleca] from comment #13)

Created attachment 9276626 [details]
Screen Shot 2022-05-15 at 10.02.18 PM.png

I just noticed that the indicator of "new" emails is cut off in normal and compact density.
I think it's a regression but I'm not sure it was caused by the new icon or any adjacent work we did here.
Anyway, it should be a very minor fix.

On which platform? On Windows with normal density it's okay. I think this is correlated with the treeitem height.

Sorry, forgot to mention. That's on macOS, no issues on Windows or Linux.

Flags: needinfo?(micah)

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/58daa42916da
Implement new icons at touch density in folderpane r=aleca

Anything else needed for this bug?

(In reply to Alessandro Castellani [:aleca] from comment #17)

Anything else needed for this bug?

Not that I know of, unless I'm missing something.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Keywords: leave-open
Blocks: 1768505
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: