Add per-global or per-realm option to enable async stack capturing
Categories
(Core :: JavaScript Engine, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox104 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Bug 1770477 needs async stack capturing, and the current options are the following:
- Make the target global a debuggee
- Flip
asyncstack_capture_debuggee_only
option and enable async stack capturing globally
Given the set of global that needs async stack is limited and also known, and also debugging API isn't necessary there, we can look into adding another option there, to introduce per-global or per-realm option to enable async stack capturing.
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
This patch adds Debugger.prototype.enableAsyncStack
and Debugger.prototype.disableAsyncStack
.
I'm not sure if this is the right place to add those functions, given it's not related to debugger.
but at least it's available to webdriver code.
If there's better place to add them, let me know.
if accessing the functionality via Gecko-side's C++ is better, I'll add public JSAPI for them.
Comment 3•2 years ago
|
||
(In reply to Tooru Fujisawa [:arai] from comment #2)
This patch adds
Debugger.prototype.enableAsyncStack
andDebugger.prototype.disableAsyncStack
.
I'm not sure if this is the right place to add those functions, given it's not related to debugger.
but at least it's available to webdriver code.If there's better place to add them, let me know.
if accessing the functionality via Gecko-side's C++ is better, I'll add public JSAPI for them.
Thanks a lot Arai!
If there's better place to add them, let me know.
IMO the feature is still related to debugging, or at least to "inspecting" the browser. So somewhere in Debugger makes sense. Maybe another option would be to add that to Debugger.Object, but I don't know if that would work for realms And it's not really better than your proposition anyway.
if accessing the functionality via Gecko-side's C++ is better, I'll add public JSAPI for them.
All our codebase is in JS, so the current patch is perfect for our usage :)
Updated•2 years ago
|
Comment 5•2 years ago
|
||
bugherder |
Description
•