Closed Bug 1776428 Opened 2 years ago Closed 2 years ago

Use enableAsyncStack instead of addDebuggee in BiDi script module

Categories

(Remote Protocol :: WebDriver BiDi, task)

task

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1770477

People

(Reporter: jdescottes, Unassigned)

References

Details

(Keywords: perf)

In Bug 1770477, we are temporarily using addDebuggee to enable async stack traces in the script module for WebDriver BiDi, but as soon as Bug 1775207 is fixed, we should switch to the APIs added there (presumably enableAsyncStack unless naming changes)

This should be about replacing:

this.#global = lazy.dbg.addDebuggee(this.messageHandler.window);

with

this.#global = lazy.dbg.makeGlobalObjectReference(this.messageHandler.window);
lazy.dbg.enableAsyncStack(this.messageHandler.window);
Points: --- → 1
Keywords: perf
Priority: -- → P1
Whiteboard: [webdriver:m4]

As discussed with Julian this bug is actually not blocking us for M4. Also given that it depends on a platform bug we should not block our M4 on it. We can use P2 and can get it fixed once the dependency has been fixed.

Priority: P1 → P2
Whiteboard: [webdriver:m4] → [webdriver:backlog]

Given that the dependency bug has been landed earlier as expected I assume that we want to make use of the new feature in M4? Lets discuss today in the triage session.

Whiteboard: [webdriver:backlog] → [webdriver:backlog][webdriver:triage]

I would actually propose to fold that in the current stack for Bug 1770477 since it didn't land yet.

Let's handle it in Bug 1770477

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE
Points: 1 → ---
Priority: P2 → --
Whiteboard: [webdriver:backlog][webdriver:triage]
You need to log in before you can comment on or make changes to this bug.