Closed Bug 1779100 Opened 2 years ago Closed 2 years ago

Re-allow entering a birthday or special date without year (avoid ux-interruption, also for migrated contacts w/o year)

Categories

(Thunderbird :: Address Book, defect, P2)

Tracking

(thunderbird_esr102+ fixed, thunderbird104 fixed)

RESOLVED FIXED
105 Branch
Tracking Status
thunderbird_esr102 + fixed
thunderbird104 --- fixed

People

(Reporter: kevin, Assigned: mkmelin)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, ux-implementation-level, ux-interruption)

Attachments

(2 files)

With Thunderbird Daily 20220711105425, it is not possible to save a contact with a birthday (or anniversary) that lacks a year. Pressing Save results in the year field gaining a pink border, suggesting it has failed validation, and save does not proceed.

Support for saving birthdays without years was added to the back-end in Bug 469209 and briefly supported, as noted in Bug 1727633, but was recently regressed. The pushlog https://hg.mozilla.org/comm-central/pushloghtml?fromchange=818289b8740deb3227ce8dfd30e763064af5414f&tochange=921aa12828e75d533ed016df3745b7ce91113a6a suggests it was regressed by Bug 1774696.

Regressed by: 1774696

I agree with Kevin and Wayne that saving a birthday without a year is a frequent scenario which we should continue to support.

Also, as we used to support this in TB 91 (dates without year), requiring the year now will blow up for all contacts not having a year whenever you change anything else on them, as it will want to force you to enter a year when you're not ready for that. That's a pretty pretty bad case of ux-interruption actually, because the only way out (short of entering a wrong year which is worse) would be to delete the entire date set. That's almost S2.

When this gets fixed (no year required), please re-allow entering February 29 (currently when there's no year, it assumes current year and limits to Feb 28).

I'm also not entirely sure if pre-emptive data validation (instead of post-facto) justifies the inconvenience of reversing d-m-y inputs, entering a birthday in reverse order seems a bit weird, although of course it's perfectly correct and maybe on the increase in forms.

Severity: -- → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P2
Summary: [AddressBook] Allow birthday without year → Allow entering a birthday or special date without year
Summary: Allow entering a birthday or special date without year → Re-allow entering a birthday or special date without year (avoid ux-interruption, also for migrated contacts w/o year)
Depends on: 1779789
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Target Milestone: --- → 105 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/aaceb4d62948
Re-allow entering a birthday or special date without year. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/161ac040269b follow-up - adjust test expecations. r=#thunderbird-reviewers,darktrojan

Comment on attachment 9286400 [details]
Bug 1779100 - Re-allow entering a birthday or special date without year. r=aleca

[Approval Request Comment]
Regression caused by (bug #): new ab
User impact if declined: data incompatibility, and can't add special date without a year
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): should be safe

Attachment #9286400 - Flags: approval-comm-esr102?
Attachment #9286400 - Flags: approval-comm-beta?

Comment on attachment 9286400 [details]
Bug 1779100 - Re-allow entering a birthday or special date without year. r=aleca

[Triage Comment]
Approved for beta

Attachment #9286400 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9286400 [details]
Bug 1779100 - Re-allow entering a birthday or special date without year. r=aleca

[Triage Comment]
Approved for esr102

Attachment #9286400 - Flags: approval-comm-esr102? → approval-comm-esr102+

Comment on attachment 9287163 [details]
Bug 1779100 - follow-up - adjust test expecations. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Attachment #9287163 - Flags: approval-comm-esr102+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: