Closed Bug 1779219 Opened 2 years ago Closed 2 years ago

Add onboarding link to QuickActions

Categories

(Firefox :: Address Bar, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
105 Branch
Tracking Status
firefox105 --- fixed

People

(Reporter: daleharvey, Assigned: daleharvey)

References

Details

Attachments

(1 file, 1 obsolete file)

Assignee: nobody → dharvey
Status: NEW → ASSIGNED
Blocks: 1782974
Pushed by dharvey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8043340f122d Add onboarding link to QuickActions. r=adw

Backed out for causing failures on browser_quickactions.js

[task 2022-08-16T21:11:49.460Z] 21:11:49     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_quickactions.js | The action is displayed - 2 == 2 - 
[task 2022-08-16T21:11:49.461Z] 21:11:49     INFO - Buffered messages finished
[task 2022-08-16T21:11:49.463Z] 21:11:49     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_quickactions.js | No results should be selected. - 1 == -1 - JS frame :: chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_quickactions.js :: test_disabled :: line 127
[task 2022-08-16T21:11:49.463Z] 21:11:49     INFO - Stack trace:
[task 2022-08-16T21:11:49.463Z] 21:11:49     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_quickactions.js:test_disabled:127
[task 2022-08-16T21:11:49.465Z] 21:11:49     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_quickactions.js | onPick for disabled action was not called - 0 == 0 - 
Flags: needinfo?(dharvey)
Pushed by dharvey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/629fc32c6f5e Add onboarding link to QuickActions. r=adw

Backed out changeset 629fc32c6f5e (Bug 1779219) for causing xpcshell failures on test_quickactions.js.
Backout link
Push with failures <--> X2
Failure Log

Argh apologies, keep making the mistake of assuming the simple patch wont break other tests, fixed and running via try

Flags: needinfo?(dharvey)
Pushed by dharvey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/20bf9adccfda Add onboarding link to QuickActions. r=adw
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch

Dale, the help page currently directs to: https://support.mozilla.org/en-US/kb/quick-actions-firefox-search-bar?as=u&utm_source=inproduct which is not found. Are/should we tracking this somewhere different?

Flags: needinfo?(dharvey)

Product and content are responsible for this and tracking seperately, it can be updated at any time so we dont need to track for release or anything, I have heard some work on it being done recently so should not be too long

Flags: needinfo?(dharvey)

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

This would usually be fine as a follow up but since we might need uplift on the follow up going to split it into a new bug

Blocks: 1786504

Comment on attachment 9290969 [details]
Bug 1779219 - Follow up to ensure onboarding button is correctly positioned. r=daisuke

Revision D155259 was moved to bug 1786504. Setting attachment 9290969 [details] to obsolete.

Attachment #9290969 - Attachment is obsolete: true

(In reply to Adrian Florinescu [:aflorinescu] from comment #10)

Dale, the help page currently directs to: https://support.mozilla.org/en-US/kb/quick-actions-firefox-search-bar?as=u&utm_source=inproduct which is not found. Are/should we tracking this somewhere different?

For the record, this is bug 1786702.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: