Closed Bug 1786504 Opened 2 years ago Closed 2 years ago

Fix onboarding link layout

Categories

(Firefox :: Address Bar, defect, P1)

defect

Tracking

()

VERIFIED FIXED
106 Branch
Tracking Status
firefox106 --- verified

People

(Reporter: daleharvey, Assigned: daleharvey)

References

Details

Attachments

(2 files)

Assignee: nobody → dharvey
Severity: -- → S3
Type: enhancement → defect
Priority: -- → P1
Pushed by dharvey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e16c8c2dbef9 Follow up to ensure onboarding button is correctly positioned. r=daisuke
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

Hey Dale,
Will the onboarding button be always positioned on the first row (currently that is the case in Firefox). Because figma specs show that whenever there is wrapping done, the button should be placed in the middle of the quickactions container. This is also the case when opening the quickaction section from the oneoff portion of the address bar drop-down.

Flags: needinfo?(dharvey)
Attached image help button position (deleted) —

Added a screenshot for a better view and comparison between current implementation and figma design.

We shouldnt actually have more than one row in any case, that is being tracked @ https://bugzilla.mozilla.org/show_bug.cgi?id=1783762

Flags: needinfo?(dharvey)

Closing this as verified fixed since the wrap up is done differently in normal mode and the current implementation looks good for quickactions searchmode.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: