344.55 - 1.54% compiler_metrics num_static_constructors / compiler_metrics num_static_constructors + 6 more (Linux, Windows) regression on Sat July 23 2022
Categories
(Core :: Audio/Video, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr91 | --- | unaffected |
firefox-esr102 | --- | unaffected |
firefox103 | --- | unaffected |
firefox104 | --- | unaffected |
firefox105 | --- | fixed |
People
(Reporter: aesanu, Assigned: az)
References
(Regression)
Details
(Keywords: perf-alert, regression)
Attachments
(1 file, 1 obsolete file)
Perfherder has detected a build_metrics performance regression from push d1b1f300857b916411d16ef35440f3955ec6bdb8. As author of one of the patches included in that push, we need your help to address this regression.
Regressions:
Ratio | Test | Platform | Options | Absolute values (old vs new) |
---|---|---|---|---|
345% | compiler_metrics num_static_constructors | windows-mingw32 | 32 clang debug | 202.00 -> 898.00 |
343% | compiler_metrics num_static_constructors | windows-mingw32 | 64 clang debug | 203.00 -> 899.00 |
79% | compiler_metrics num_static_constructors | linux64 | base-toolchains-clang | 204.00 -> 366.00 |
34% | compiler_metrics num_static_constructors | linux64 | base-toolchains | 328.00 -> 439.00 |
2% | compiler_metrics num_static_constructors | windows2012-aarch64 | aarch64 | 192.00 -> 195.00 |
2% | compiler_metrics num_static_constructors | windows2012-64 | 193.00 -> 196.00 | |
2% | compiler_metrics num_static_constructors | windows2012-32 | 195.00 -> 198.00 | |
2% | compiler_metrics num_static_constructors | windows2012-64 | fuzzing | 195.00 -> 198.00 |
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.
For more information on performance sheriffing please see our FAQ.
Updated•2 years ago
|
Comment 1•2 years ago
|
||
Guessing this is expected in which case it's wontfix. but I'll wait for :az to chime in here.
This does need a fix -- working on one now + aiming to have a fix out by EOD.
Comment 5•2 years ago
|
||
As a general comment for the future, common practice is for the commit message to summarize what the patch is doing rather than restating the problem being fixed. Thanks!
Comment 7•2 years ago
|
||
The patch landed in nightly and beta is affected.
:az, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox104
towontfix
.
For more information, please visit auto_nag documentation.
Comment 8•2 years ago
|
||
Comment on attachment 9287350 [details]
Bug 1781259 - 344.55 - 1.54% compiler_metrics num_static_constructors / compiler_metrics num_static_constructors + 6 more (Linux, Windows) regression on Sat July 23 2022 r=alwu
Revision D152954 was moved to bug 1709184. Setting attachment 9287350 [details] to obsolete.
Took a look at this again / the perfherder graphs and reopening as there doesn't appear to be a change. I moved the earlier patch and will fix this regression as part of that work as well, aiming for Monday.
Updated•2 years ago
|
Comment 10•2 years ago
|
||
Backed out as requested.
Backout link: https://hg.mozilla.org/integration/autoland/rev/1d796f7a78de053c8cf093b27aea69a0145e3873
Updated•2 years ago
|
Assignee | ||
Comment 11•2 years ago
|
||
Assignee | ||
Comment 12•2 years ago
|
||
Adding a dependency on bug 1782837 as I've been running into errors when attempting to do mingw32 builds on try. So far I've been able to reduce the constructor count for Linux but not for Windows -- will investigate further tomorrow.
Comment 13•2 years ago
|
||
Comment 14•2 years ago
|
||
bugherder |
Description
•