Closed Bug 1766307 Opened 2 years ago Closed 2 years ago

Enable PDMFactory to report per-codec SW/HW decode support information

Categories

(Core :: Audio/Video, enhancement)

Product:
Core
Component:
Audio/Video
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
105 Branch
Tracking Flags:
Tracking Status
firefox104 --- wontfix
firefox105 --- fixed

People

(Reporter: az, Assigned: az)

References

Details

Attachments

(5 files)

WIP: Enable PDMFactory::Supports/SupportsMimeType to return HW/SW decode info
(deleted), text/x-phabricator-request
Details
Bug 1766307 - Enable PDMFactory::Supports/SupportsMimeType to process+return HW/SW decode info r=#media-playback-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1766307 - Store media codec support info during IPC broadcast r=#media-playback-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1766307 - Add H264 include / namespace specifier for PlanarYCbCrImage to fix try build errors r=#media-playback-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1766307 - Add gtests for MediaCodecsSupport r=#media-playback-reviewers
(deleted), text/x-phabricator-request
Details

Update PDMFactory's enum class MediaCodecsSupported and EnumSet<MediaCodecs> to store per-codec SW/HW decode support information returned from PDMs. Update supporting methods PDMFactory::Supports, PDMFactory::Supported, and PDMFactory::SupportsMimeType to report per-codec SW/HW acceleration using the updated MediaCodecsSupported.

Blocks: 1766310

WIP, getting feedback on approach

Attachment #9280287 - Attachment description: WIP: Enable PDMFactory::Supports/SupportsMimeType to process+return HW/SW decode info → Enable PDMFactory::Supports/SupportsMimeType to process+return HW/SW decode info
Attachment #9280287 - Attachment description: Enable PDMFactory::Supports/SupportsMimeType to process+return HW/SW decode info → Bug 1766307 - Enable PDMFactory::Supports/SupportsMimeType to process+return HW/SW decode info
Attachment #9280287 - Attachment description: Bug 1766307 - Enable PDMFactory::Supports/SupportsMimeType to process+return HW/SW decode info → WIP: Bug 1766307 - Enable PDMFactory::Supports/SupportsMimeType to process+return HW/SW decode info
Attachment #9280287 - Attachment description: WIP: Bug 1766307 - Enable PDMFactory::Supports/SupportsMimeType to process+return HW/SW decode info → Bug 1766307 - Enable PDMFactory::Supports/SupportsMimeType to process+return HW/SW decode info r=#media-playback-reviewers
Attachment #9281728 - Attachment description: WIP: Bug 1766307 - Store media codec support info during IPC broadcast → Bug 1766307 - Store media codec support info during IPC broadcast r=#media-playback-reviewers
Attachment #9281731 - Attachment description: WIP: Bug 1766307 - Add H264 include / namespace specifier for PlanarYCbCrImage to fix try build errors → Bug 1766307 - Add H264 include / namespace specifier for PlanarYCbCrImage to fix try build errors r=#media-playback-reviewers
Pushed by azebrowski@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/81ccd31d0f07 Enable PDMFactory::Supports/SupportsMimeType to process+return HW/SW decode info r=media-playback-reviewers,alwu https://hg.mozilla.org/integration/autoland/rev/67c5fbd546a1 Store media codec support info during IPC broadcast r=media-playback-reviewers,alwu https://hg.mozilla.org/integration/autoland/rev/5fb04c68ae7a Add H264 include / namespace specifier for PlanarYCbCrImage to fix try build errors r=media-playback-reviewers,padenot https://hg.mozilla.org/integration/autoland/rev/e383703e28cf Add gtests for MediaCodecsSupport r=media-playback-reviewers,alwu

Backed out for causing build bustages on UtilityAudioDecoderParent.cpp

Backout link

Push with failures

Failure log // Failure log 2

Flags: needinfo?(azebrowski)
Pushed by azebrowski@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a7ffa6f44fe8 Enable PDMFactory::Supports/SupportsMimeType to process+return HW/SW decode info r=media-playback-reviewers,alwu https://hg.mozilla.org/integration/autoland/rev/c8cc5e0c89dd Store media codec support info during IPC broadcast r=media-playback-reviewers,alwu https://hg.mozilla.org/integration/autoland/rev/19800bb8974e Add H264 include / namespace specifier for PlanarYCbCrImage to fix try build errors r=media-playback-reviewers,padenot https://hg.mozilla.org/integration/autoland/rev/50918938a839 Add gtests for MediaCodecsSupport r=media-playback-reviewers,alwu

Backed out for causing build bustages on Logging.h

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/workspace/obj-build/dist/include/mozilla/Logging.h:284:61: error: format '%d' expects argument of type 'int', but argument 4 has type 'mozilla::media::MediaCodecsSupport' [-Werror=format=]
Pushed by azebrowski@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/286f517010ab Enable PDMFactory::Supports/SupportsMimeType to process+return HW/SW decode info r=media-playback-reviewers,alwu https://hg.mozilla.org/integration/autoland/rev/91b987e61d01 Store media codec support info during IPC broadcast r=media-playback-reviewers,alwu https://hg.mozilla.org/integration/autoland/rev/6f5d35b41456 Add H264 include / namespace specifier for PlanarYCbCrImage to fix try build errors r=media-playback-reviewers,padenot https://hg.mozilla.org/integration/autoland/rev/d1b1f300857b Add gtests for MediaCodecsSupport r=media-playback-reviewers,alwu
Regressions: 1782313
Flags: needinfo?(azebrowski)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: