Closed Bug 1782313 Opened 2 years ago Closed 2 years ago

Fix MCSInfo's shutdown listener to avoid errors if shutdown is already in process when the listener is started.

Categories

(Core :: Audio/Video, defect, P1)

Product:
Core
Component:
Audio/Video
Version:
Firefox 104
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
105 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- unaffected
firefox103 --- unaffected
firefox104 --- fixed
firefox105 + fixed

People

(Reporter: az, Assigned: az)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

Bug 1782313 - Fix MCSInfo's shutdown listener to avoid errors if shutdown is already in process when the listener is started.
(deleted), text/x-phabricator-request
Details
Bug 1782313 - Add XPCOM shutdown checks + improve shutdown listener for MCSInfo. Should fix intermittents caused by MCSInfo object being instantiated during XPCOM shutdown and may reduce static constructor overhead. r=jstutte
(deleted), text/x-phabricator-request
Details
Bug 1782313 - Add XPCOM shutdown checks + improve shutdown listener for MCSInfo. Should fix intermittents caused by MCSInfo object being instantiated during XPCOM shutdown. r=alwu,jrmuizel,kinetik
(deleted), text/x-phabricator-request
Details
No description provided.

Set release status flags based on info from the regressing bug 1766307

status-firefox103: --- → unaffected
status-firefox104: --- → affected
status-firefox105: --- → affected
status-firefox-esr102: --- → unaffected
status-firefox-esr91: --- → unaffected

Hi, I assume you intended to move D152954 here. And I added some comments to the already published patch, would you mind to take a look? Thanks!

Flags: needinfo?(azebrowski)

Remove XPCOM shutdown listener from MCSInfo to remove possibility of the listener starting after the shutdown process has already begun.

Hi :jstutte, thanks for the heads up + comments! Just wanted to let you know that I read + responded, and will update tomorrow. Thanks!

Flags: needinfo?(azebrowski)
Attachment #9288522 - Attachment description: Bug 1782313 - Add XPCOM shutdown checks + improve shutdown listener for MCSInfo. Should fix intermittents caused by MCSInfo object being instantiated during XPCOM shutdown and may reduce static constructor overhead. → Bug 1782313 - Add XPCOM shutdown checks + improve shutdown listener for MCSInfo. Should fix intermittents caused by MCSInfo object being instantiated during XPCOM shutdown and may reduce static constructor overhead. r=jstutte
Pushed by azebrowski@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/023fe8af666e Add XPCOM shutdown checks + improve shutdown listener for MCSInfo. Should fix intermittents caused by MCSInfo object being instantiated during XPCOM shutdown and may reduce static constructor overhead. r=media-playback-reviewers,alwu,jrmuizel

Backed out changeset 023fe8af666e (bug 1782313) for causing gtest failures in MediaCodecsSupport

Backout link: https://hg.mozilla.org/integration/autoland/rev/f69ff4d8bbf2dc344dc5ac0a2aab6de7574850c1

Push with failures

Failure log

TEST-UNEXPECTED-FAIL | MediaCodecsSupport.GetMediaCodecsSupportedString | Value of: supportString.Equals( "Codec support information:\nH264 SW\nH264 HW\nVP8 SW"_ns)
Flags: needinfo?(azebrowski)

The bug is marked as tracked for firefox105 (nightly). However, the bug still has low severity.

:jimm, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Flags: needinfo?(jmathies)
Attachment #9289897 - Attachment description: Bug 1782313 - Add XPCOM shutdown checks + improve shutdown listener for MCSInfo. Should fix intermittents caused by MCSInfo object being instantiated during XPCOM shutdown. r=jrmuizel,jstutte,kinetik → Bug 1782313 - Add XPCOM shutdown checks + improve shutdown listener for MCSInfo. Should fix intermittents caused by MCSInfo object being instantiated during XPCOM shutdown. r=alwu,jrmuizel,kinetik
Pushed by azebrowski@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d0ee30333fa0 Add XPCOM shutdown checks + improve shutdown listener for MCSInfo. Should fix intermittents caused by MCSInfo object being instantiated during XPCOM shutdown. r=kinetik,media-playback-reviewers

https://hg.mozilla.org/mozilla-central/rev/d0ee30333fa0

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox105: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
Flags: needinfo?(azebrowski)
Flags: needinfo?(jmathies)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: