Closed Bug 1782318 Opened 2 years ago Closed 2 years ago

Pocket newtab recent saves default image

Categories

(Firefox :: Pocket, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
106 Branch
Tracking Status
firefox106 --- fixed

People

(Reporter: thecount, Assigned: thecount)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

For recent saves that don't have an available thumbnail, we should display something.

Assignee: nobody → sdowne

Steps to test:

  1. Set browser.newtabpage.activity-stream.discoverystream.recentSaves.enabled to true
  2. Log into Pocket.
  3. Save any page to Pocket that does not have a thumbnail, like this one: https://searchfox.org/mozilla-central/source/browser/components/pocket/content/panels/js/components/Home/Home.jsx
  4. Open a newtab.
  5. Scroll down to the recent saves section.

Expected: You should see the newly saved article with a generic thumbnail, and not a blank white thumbnail.

You can also try a few other pages that don't have thumbnails, I find them pretty easily, but searchfox is a good place.

Each page you save should have a varied, but consistent thumbnail. Duplicates are possible though.

Attachment #9290715 - Attachment description: WIP: Bug 1782318 - Pocket newtab show placeholder thumbnail images for cards without images. → Bug 1782318 - Pocket newtab show placeholder thumbnail images for cards without images.
Pushed by sdowne@getpocket.com: https://hg.mozilla.org/integration/autoland/rev/8f5109ad1e7f Pocket newtab show placeholder thumbnail images for cards without images. r=gvn
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
Regressions: 1787167
Attached image example.png (deleted) —
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: