Closed Bug 1787167 Opened 2 years ago Closed 2 years ago

Perma browser/base/content/test/performance/browser_startup_images.js | single tracking bug when Gecko 106 merges to Beta on 2022-09-19

Categories

(Firefox :: Firefox View, defect, P1)

Firefox 106
defect
Points:
1

Tracking

()

VERIFIED FIXED
106 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- unaffected
firefox104 --- unaffected
firefox105 --- unaffected
firefox106 + verified

People

(Reporter: mlaza, Assigned: dao)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [fidefe-2022-mr1-firefox-view])

Attachments

(1 file)

Central-as-beta simulation

How to run these simulations

Failure log:

[task 2022-08-25T11:14:39.323Z] 11:14:39     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://global/skin/icons/pocket-outline.svg should have been shown. - 
[task 2022-08-25T11:14:39.324Z] 11:14:39     INFO - Buffered messages finished
[task 2022-08-25T11:14:39.327Z] 11:14:39     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://branding/content/icon32.png should have been shown. - 
[task 2022-08-25T11:14:39.328Z] 11:14:39     INFO - Stack trace:
[task 2022-08-25T11:14:39.329Z] 11:14:39     INFO - chrome://mochikit/content/browser-test.js:test_ok:1440
[task 2022-08-25T11:14:39.330Z] 11:14:39     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_images.js:null:120
[task 2022-08-25T11:14:39.339Z] 11:14:39     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/content/static-robot.png should have been shown. - 

Hello Scott, could you please take a look at this failure? It could be regressed by Bug 1782318. Thanks

Flags: needinfo?(sdowne)
Summary: Perma early beta browser/base/content/test/performance/browser_startup_images.js | single tracking bug when Gecko 106 merges to Beta on 2022-09-12 → Perma browser/base/content/test/performance/browser_startup_images.js | single tracking bug when Gecko 106 merges to Beta on 2022-09-12

I'm not sure how bug 1782318 could have caused this. bug 1782318 is happening almost exclusively in a preffed off feature we are going to experiment with.

Unless the test is somehow setting up images with no image source.

Either way I'll investigate because I've been surprised before with tests.

Flags: needinfo?(sdowne)

Is there a way I can get this test running locally? If I run it locally, it passes, so I suspect I am missing proper parameters.

If it passes for debug for you, could you verify the central-as-beta config has been activated?

Is there a way I can run that with ./mach test, and not ./mach try? That way I can debug it if needed?

I'm not sure what to do with central-as-beta config or setting debug to true, but I'll keep looking.

So I got it running with debug true, via mozconfig.

I am still looking into what central-as-beta config is.

So far with just debug, I get the same errors before and after the patch in bug 1782318.

Is central-as-beta essentially applying the patch to beta, then running the tests?

If you want to check that your patch works on a central-as-beta simulation, make sure your patch is imported and then run ./mach try release -v 106.0b1 --tasks release-sim --migration central-to-beta If not all the jobs shall run (e.g. to verify a test fix), append --stage-changes to the command, hg commit -m "Early beta sim" and select the jobs with ./mach try chooser --no-artifact.

(In reply to Scott [:thecount] Downe from comment #8)

Is central-as-beta essentially applying the patch to beta, then running the tests?

The Central as Beta simulation tests the recent nightly changes in order to prepare it for a Beta merge

I ran a bunch of try builds with that command, and it did fail once, but I am unsure if that is significant.

I'm trying to get some help on this as I have no clue what to try next or how this might be connected.

If you have any other ideas as to what else this might be, it might be worth investigating other possibilities.

These three try runs using the above command with only my commit on top, and nothing after it, show no fails. Could it be another commit that happened after mine that caused these failures?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec16736342e29f69cf60a168148b9363ccfa1a64
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b433752ffdf5e5a1a20b6458814f87404fc75e4
https://treeherder.mozilla.org/#/jobs?repo=try&revision=43d81bed3b9ee1331a1214545b499994a5e53b78

Flags: needinfo?(mlaza)

Hi Scott!
Atm Aryx is investigating which change regressed this.

Flags: needinfo?(mlaza)

It's not from one of these: bug 1782318, bug 1771311, bug 1777198. Will investigate further.

No longer regressed by: 1782318

This is a regression from bug 1786293 and is reproducible with debug builds in central-as-beta configuration.

Flags: needinfo?(dao+bmo)
Regressed by: 1786293

I suspect the solution is likely going to be change the pref value for beta.

Component: General → Firefox View
Whiteboard: [fidefe-2022-mr1-firefox-view]
Summary: Perma browser/base/content/test/performance/browser_startup_images.js | single tracking bug when Gecko 106 merges to Beta on 2022-09-12 → Perma browser/base/content/test/performance/browser_startup_images.js | single tracking bug when Gecko 106 merges to Beta on 2022-09-19

(In reply to :Gijs (he/him) from comment #16)

I suspect the solution is likely going to be change the pref value for beta.

Yeah.

Blocks: firefox-view
Flags: needinfo?(dao+bmo)
Severity: -- → S2
Priority: -- → P1

(In reply to Dão Gottwald [::dao] from comment #17)

(In reply to :Gijs (he/him) from comment #16)

I suspect the solution is likely going to be change the pref value for beta.

Yeah.

I'm not clear on which pref needs to be changed to what value to get this to pass? Can you elaborate on the next steps needed here :dao?

Flags: needinfo?(dao+bmo)
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED

(In reply to Sam Foster [:sfoster] (he/him) from comment #19)

(In reply to Dão Gottwald [::dao] from comment #17)

(In reply to :Gijs (he/him) from comment #16)

I suspect the solution is likely going to be change the pref value for beta.

Yeah.

I'm not clear on which pref needs to be changed to what value to get this to pass? Can you elaborate on the next steps needed here :dao?

See the above patch :)

Flags: needinfo?(dao+bmo)
Points: --- → 1
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cb5977c8af25 Let Firefox View ride the release train. r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

Verified fixed in today's central-as-beta simulation

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: