Closed Bug 1783684 Opened 2 years ago Closed 2 years ago

Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
107 Branch
Iteration:
107.1 - Sept 19 - Sept 30
Tracking Status
firefox106 --- verified
firefox107 --- verified

People

(Reporter: Mardak, Assigned: halemu)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

Attached image design idea for light and dark (deleted) —

Potentially this can reuse some state used by bug 1778994 Firefox View Feature Callout.

https://www.figma.com/file/mrjF8OroTxjSZglHUjRybQ/Product-tour?node-id=455%3A33696

Depends on: 1784101
Assignee: edilee → nobody
Iteration: 105.2 - Aug 8 - Aug 19 → 106.1 - Aug 22 - Sept 2
Assignee: nobody → halemu
Depends on: 1788991
Iteration: 106.1 - Aug 22 - Sept 2 → 106.2 - Sept 5 - Sept 16

Where/How can I get the asset for the 'lightning' icon?

Screen Shot 2022-09-06 at 4.52.16 PM

Flags: needinfo?(edilee)

You could export it from figma but probably want to make sure we can change the color with css like other svg icons.

But maybe also double check if we actually want the lightning bolt icon over say some existing icon we have?

E.g., lightbulb https://searchfox.org/mozilla-central/source/browser/components/newtab/data/content/assets/glyph-cfr-feature-16.svg
sparkles https://searchfox.org/mozilla-central/source/toolkit/themes/shared/icons/highlights.svg
present https://searchfox.org/mozilla-central/source/toolkit/themes/shared/icons/whatsnew.svg

Flags: needinfo?(edilee) → needinfo?(vtay)

I believe Tati intended with the lightning bolt icon; in dark mode, the outline of the bolt will be white.
If this cannot be done, we could use the lightbulb

Flags: needinfo?(vtay)
Blocks: 1790465
Attachment #9293352 - Attachment description: WIP: Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it → Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=mviar

Per product, we'll launch the spotlight when a user navigates to about:firefoxview and they have yet to advance in the feature tour. This differs from our initial approach of launching the spotlight when the user clicks the primary CTA in the CFR panel message.

So, the spotlight message will become its own separate message targeting users with a pref value of "browser.firefox-view.feature-tour" === "{"message":"FIREFOX_VIEW_FEATURE_TOUR","screen":"FEATURE_CALLOUT_1","complete":false}" with a trigger of the url being about:firefoxview.

Blocks: 1790835
Blocks: 1790880
No longer blocks: 1790880
Depends on: 1790880
Attachment #9293352 - Attachment description: Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=mviar → WIP: Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it
Attachment #9293352 - Attachment description: WIP: Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it → Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it
Attachment #9293352 - Attachment description: Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it → Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=mardak
Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4eed140eab3f Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=Mardak
Iteration: 106.2 - Sept 5 - Sept 16 → 107.1 - Sept 19 - Sept 30

[Tracking Requested - why for this release]:
CFR is needed for Fx106 continuous onboarding , there is decision pending if the CFR should be local or remotely configured which can help decide next step and if uplift is needed.

After discussing with product, We will be uplifting images, and JSON in PanelTestPovider as part of this bug. CFR will be remotely configured.

Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/398b10abc7c1 Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=Mardak
Flags: needinfo?(halemu)
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
Flags: qe-verify?
Blocks: 1792226

I have verified this enhancement on the Light and Dark theme using the latest Firefox Nightly 107.0a1 (Build ID: 20220929014928) on Windows 10x64, macOS 12.3.1 and Linux Mint 20.2x64 and I can confirm the following:

  • The Firefox View CFR message is triggered for users with a profile age of at least 2 days and 3 tabs closed, but have not opened yet the Firefox View page.
Status: RESOLVED → VERIFIED
Flags: qe-verify?

Comment on attachment 9293352 [details]
Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=mardak

Beta/Release Uplift Approval Request

  • User impact if declined: Users will not be guided to begin the Firefox View feature tour and miss out on this new feature.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: - From Terminal run: ./mach run --temp-profile
  • In about:config, ensure the pref browser.firefox-view.view-count is set to 0
  • Open 4 tabs in the browser
  • Close the 3 tabs:
  • In the last tab, you should see the Firefox View CFR message appear. It should be anchored to the Firefox View Icon in the top left.
  • The 'lightning' icon should have a different color in darkmode
  • Clicking 'Not now' or clicking anywhere outside of the message should close the message
  • Clicking 'Try it' should open the Firefox view tab
  • List of other uplifts needed: Bug 1792226
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This message does not affect the content the user is exploring on a given page and uses an existing messaging surface that has been used in the past.
  • String changes made/needed: Yes
  • Is Android affected?: No
Attachment #9293352 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9293352 [details]
Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=mardak

Approved for 106.0b7, thanks.

Attachment #9293352 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have verified this enhancement using the latest Firefox Beta 106.0b7 (Build ID: 20221002185807) on Windows 10x64, macOS 12.3.1 and Linux Mint 20.3 and I can confirm the following:

  • The Firefox View CFR message is triggered for users with a profile age of at least 2 days and 3 tabs closed, but have not opened yet the Firefox View page.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: