Add Messaging Trigger for the nth Closed Tab
Categories
(Firefox :: Messaging System, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox106 | --- | verified |
People
(Reporter: mviar, Assigned: mviar)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details |
To enable the message created in bug 1783684, add a messaging trigger for the user closing the nth tab in a session.
We should be able to use something like SessionStore.getClosedTabData(window).length to determine the number of closed tabs.
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Updated•2 years ago
|
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
||
Comment 4•2 years ago
|
||
Backed out changeset 658be3acc41a (bug 1788991) for causing bc failures in toolkit/components/messaging-system/schemas/TriggerActionSchemas/test/browser/browser_asrouter_trigger_docs.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/d42949e00612e6f14ef5e0f5da4af9141572bb95
TEST-UNEXPECTED-FAIL | toolkit/components/messaging-system/schemas/TriggerActionSchemas/test/browser/browser_asrouter_trigger_docs.js | Uncaught exception in test - at :0 - SyntaxError: JSON.parse: expected double-quoted property name at line 250 column 11 of the JSON data
|
|
Assignee | |
Comment 5•2 years ago
|
||
Ah, this test didn't run on my try auto run. Will be sure to run manually next time I update schemas. I've removed the trailing comma and will attept to reland.
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
|
||
Comment 8•2 years ago
|
||
I have verified this enhancement using the latest Firefox Beta 106.0b7 (Build ID: 20221002185807) on Windows 10x64, macOS 12.3.1 and Linux Mint 20.3 and I can confirm the following:
- The Firefox View CFR message is triggered after the 3 closed tabs and having a profile age of at least 2 days.
Description
•